'Solution' #722
Open
'Solution' #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrykivd
approved these changes
Oct 9, 2023
|
All right👍 |
fsocie7y
suggested changes
Oct 10, 2023
app/main.py
Outdated
|
|
||
|
|
||
| class Carnivore(Animal): | ||
| def bite(self, herbivore: Herbivore) -> None: |
There was a problem hiding this comment.
you don't need self here, so make this method static
LiudmylaKulinchenko
suggested changes
Oct 11, 2023
app/main.py
Outdated
|
|
||
| class Carnivore(Animal): | ||
| @staticmethod | ||
| def bite(herbivore: Herbivore) -> None: |
There was a problem hiding this comment.
Fix annotations and parameter name. If this function gets only Herbivore instances, you won't need the check in the 30 line
app/main.py
Outdated
| class Carnivore(Animal): | ||
| @staticmethod | ||
| def bite(herbivore: Herbivore) -> None: | ||
| if isinstance(herbivore, Herbivore) and herbivore.hidden is not True: |
There was a problem hiding this comment.
herbivore.hidden is not True looks really tough to understand 😬 Use not herbivore.hidden
fsocie7y
suggested changes
Oct 13, 2023
app/main.py
Outdated
| Animal.alive.append(self) | ||
|
|
||
| def __repr__(self) -> str: | ||
| return "{{Name: {}, Health: {}, Hidden: {}}}".format( |
There was a problem hiding this comment.
better use f-string instead of .format()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.