-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #723
base: master
Are you sure you want to change the base?
Solution #723
Conversation
app/main.py
Outdated
return "{" + f"Name: {self.name}, " \ | ||
f"Health: {self.health}, " \ | ||
f"Hidden: {self.hidden}" + "}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
U can use brackets instead of linebreaker here
app/main.py
Outdated
|
||
|
||
class Carnivore(Animal): | ||
def bite(self, herbivore: Herbivore) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you don't need self here, so make this method static
app/main.py
Outdated
if isinstance(herbivore, Herbivore): | ||
herbivore.health -= 50 if not herbivore.hidden else 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
u can check it in one condition)
app/main.py
Outdated
if isinstance(herbivore, Herbivore) and not herbivore.hidden: | ||
herbivore.health -= 50 | ||
if herbivore.health <= 0: | ||
super(Herbivore, herbivore).alive.remove(herbivore) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
U can use herbivore here to access an attribute class
app/main.py
Outdated
return ("{" + f"Name: {self.name}, " | ||
f"Health: {self.health}, " | ||
f"Hidden: {self.hidden}" + "}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
U don't need concatenation here, you can just add curly braces directly inside a string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix that
app/main.py
Outdated
return ("{" + f"Name: {self.name}, " | ||
f"Health: {self.health}, " | ||
f"Hidden: {self.hidden}" + "}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix that
app/main.py
Outdated
|
||
class Carnivore(Animal): | ||
@staticmethod | ||
def bite(herbivore: Herbivore) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix annotation and variable name. If there only Herbivores will be passed in the function, you won't need the check in the next line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well done ^_^
No description provided.