Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #732

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Solution #732

wants to merge 3 commits into from

Conversation

OleksandrMV
Copy link

No description provided.

app/main.py Outdated
Comment on lines 33 to 36
if not self.hidden:
self.hidden = True
else:
self.hidden = False

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can simplify this code

app/main.py Outdated
Comment on lines 33 to 36
if not self.hidden:
self.hidden = True
else:
self.hidden = False

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if not self.hidden:
self.hidden = True
else:
self.hidden = False
self.hidden = not self.hidden

app/main.py Outdated

class Carnivore(Animal):
def bite(self, other: Animal) -> None:
if not other.hidden and not isinstance(other, Carnivore):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if not other.hidden and not isinstance(other, Carnivore):
if not other.hidden and isinstance(other, Herbivore):

Due to task we can only bite Herbivore

Copy link

@ArsenPidhoretskyi ArsenPidhoretskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants