'Solution' #736
Open
'Solution' #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiudmylaKulinchenko
suggested changes
Oct 17, 2023
app/main.py
Outdated
|
|
||
| @staticmethod | ||
| def bite(herbivore: Herbivore) -> None: | ||
| if not isinstance(herbivore, Carnivore) and not herbivore.hidden: |
There was a problem hiding this comment.
You should check here if it is a herbivore
app/main.py
Outdated
| class Carnivore(Animal): | ||
|
|
||
| @staticmethod | ||
| def bite(herbivore: Herbivore) -> None: |
There was a problem hiding this comment.
Fix annotation and parameter name, your function gets not only herbivores here
app/main.py
Outdated
Comment on lines
35
to
38
| class Herbivore(Animal): | ||
|
|
||
| def hide(self) -> None: | ||
| self.hidden = not self.hidden |
There was a problem hiding this comment.
define the class before Carnivore to have consistent logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.