Solution #751
Open
Solution #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavlejviki
suggested changes
Oct 25, 2023
app/main.py
Outdated
| def __init__(self, name: str, health: int = 100) -> None: | ||
| self.name = name | ||
| self.health = health | ||
| self.hidden = False |
There was a problem hiding this comment.
Don't hardcode the value for self.hidden. add it to parameters
Dimosphen1
suggested changes
Oct 26, 2023
app/main.py
Outdated
|
|
||
|
|
||
| class Carnivore(Animal): | ||
| def bite(self, herbivore: int) -> None: |
There was a problem hiding this comment.
Change your type annotation, herbivore should not be int.
Dimosphen1
suggested changes
Oct 26, 2023
app/main.py
Outdated
|
|
||
|
|
||
| class Carnivore(Animal): | ||
| def bite(self, herbivore: "Herbivore") -> None: |
There was a problem hiding this comment.
Do not use quotes "" in type annotations, declare class directly to indicate that you expect its instance as an input. Use from __future__ import annotations in case you face issues with this syntaxis.
app/main.py
Outdated
| self, | ||
| name: str, | ||
| health: int = 100, | ||
| hidden: bool = False |
There was a problem hiding this comment.
Indicate in type annotation that health and hidden are optional arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.