added solution #913
Open
added solution #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiudmylaKulinchenko
suggested changes
Feb 6, 2024
app/main.py
Outdated
Comment on lines
21
to
24
| name = "{Name: " + str(self.name) | ||
| health = ", Health: " + str(self.health) | ||
| hidden = ", Hidden: " + str(self.hidden) + "}" | ||
| return name + health + hidden |
There was a problem hiding this comment.
explicitly defining the string that should be returned will improve the readability
Just use f-strings and parentheses to split into lines
app/main.py
Outdated
| class Carnivore(Animal): | ||
|
|
||
| @staticmethod | ||
| def bite(animal: Union[Herbivore, Carnivore]) -> None: |
There was a problem hiding this comment.
You can use Animal class for annotations here, it will include Herbivore, Carnivore and other classes, that could be created in the future
app/main.py
Outdated
|
|
||
| @staticmethod | ||
| def bite(animal: Union[Herbivore, Carnivore]) -> None: | ||
| if animal.hidden is False and isinstance(animal, Herbivore): |
There was a problem hiding this comment.
You can use not in the condition
if not animal.hidden
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.