Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #887

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions app/battle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
from app.models.knight import Knight


@staticmethod
def battle(knights: str) -> dict:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type hint for knights should be dict instead of str since you are accessing it as a dictionary.

lancelot = Knight(**knights["lancelot"])
arthur = Knight(**knights["arthur"])
mordred = Knight(**knights["mordred"])
red_knight = Knight(**knights["red_knight"])

lancelot.take_damage(mordred.power)
mordred.take_damage(lancelot.power)
Comment on lines +11 to +12
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The damage calculation does not account for the knights' protection. According to the task description, you should subtract the knight's protection from the opponent's power when calculating damage.


arthur.take_damage(red_knight.power)
red_knight.take_damage(arthur.power)
Comment on lines +14 to +15
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, the damage calculation here should consider the knights' protection as described in the task requirements.


return {
lancelot.name: lancelot.hp,
arthur.name: arthur.hp,
mordred.name: mordred.hp,
red_knight.name: red_knight.hp
}
86 changes: 86 additions & 0 deletions app/knights.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,86 @@
KNIGHTS = {
"lancelot": {
"name": "Lancelot",
"power": 35,
"hp": 100,
"armour": [],
"weapon": {
"name": "Metal Sword",
"power": 50,
},
"potion": None,
},
"arthur": {
"name": "Arthur",
"power": 45,
"hp": 75,
"armour": [
{
"part": "helmet",
"protection": 15,
},
{
"part": "breastplate",
"protection": 20,
},
{
"part": "boots",
"protection": 10,
}
],
"weapon": {
"name": "Two-handed Sword",
"power": 55,
},
"potion": None,
},
"mordred": {
"name": "Mordred",
"power": 30,
"hp": 90,
"armour": [
{
"part": "breastplate",
"protection": 15,
},
{
"part": "boots",
"protection": 10,
}
],
"weapon": {
"name": "Poisoned Sword",
"power": 60,
},
"potion": {
"name": "Berserk",
"effect": {
"power": +15,
"hp": -5,
"protection": +10,
}
}
},
"red_knight": {
"name": "Red Knight",
"power": 40,
"hp": 70,
"armour": [
{
"part": "breastplate",
"protection": 25,
}
],
"weapon": {
"name": "Sword",
"power": 45
},
"potion": {
"name": "Blessing",
"effect": {
"hp": +10,
"power": +5,
}
}
}
}
217 changes: 5 additions & 212 deletions app/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,214 +1,7 @@
KNIGHTS = {
"lancelot": {
"name": "Lancelot",
"power": 35,
"hp": 100,
"armour": [],
"weapon": {
"name": "Metal Sword",
"power": 50,
},
"potion": None,
},
"arthur": {
"name": "Arthur",
"power": 45,
"hp": 75,
"armour": [
{
"part": "helmet",
"protection": 15,
},
{
"part": "breastplate",
"protection": 20,
},
{
"part": "boots",
"protection": 10,
}
],
"weapon": {
"name": "Two-handed Sword",
"power": 55,
},
"potion": None,
},
"mordred": {
"name": "Mordred",
"power": 30,
"hp": 90,
"armour": [
{
"part": "breastplate",
"protection": 15,
},
{
"part": "boots",
"protection": 10,
}
],
"weapon": {
"name": "Poisoned Sword",
"power": 60,
},
"potion": {
"name": "Berserk",
"effect": {
"power": +15,
"hp": -5,
"protection": +10,
}
}
},
"red_knight": {
"name": "Red Knight",
"power": 40,
"hp": 70,
"armour": [
{
"part": "breastplate",
"protection": 25,
}
],
"weapon": {
"name": "Sword",
"power": 45
},
"potion": {
"name": "Blessing",
"effect": {
"hp": +10,
"power": +5,
}
}
}
}
from app.battle import battle
from app.knights import KNIGHTS


def battle(knightsConfig):
# BATTLE PREPARATIONS:

# lancelot
lancelot = knightsConfig["lancelot"]

# apply armour
lancelot["protection"] = 0
for a in lancelot["armour"]:
lancelot["protection"] += a["protection"]

# apply weapon
lancelot["power"] += lancelot["weapon"]["power"]

# apply potion if exist
if lancelot["potion"] is not None:
if "power" in lancelot["potion"]["effect"]:
lancelot["power"] += lancelot["potion"]["effect"]["power"]

if "protection" in lancelot["potion"]["effect"]:
lancelot["protection"] += lancelot["potion"]["effect"]["protection"]

if "hp" in lancelot["potion"]["effect"]:
lancelot["hp"] += lancelot["potion"]["effect"]["hp"]

# arthur
arthur = knightsConfig["arthur"]

# apply armour
arthur["protection"] = 0
for a in arthur["armour"]:
arthur["protection"] += a["protection"]

# apply weapon
arthur["power"] += arthur["weapon"]["power"]

# apply potion if exist
if arthur["potion"] is not None:
if "power" in arthur["potion"]["effect"]:
arthur["power"] += arthur["potion"]["effect"]["power"]

if "protection" in arthur["potion"]["effect"]:
arthur["protection"] += arthur["potion"]["effect"]["protection"]

if "hp" in arthur["potion"]["effect"]:
arthur["hp"] += arthur["potion"]["effect"]["hp"]

# mordred
mordred = knightsConfig["mordred"]

# apply armour
mordred["protection"] = 0
for a in mordred["armour"]:
mordred["protection"] += a["protection"]

# apply weapon
mordred["power"] += mordred["weapon"]["power"]

# apply potion if exist
if mordred["potion"] is not None:
if "power" in mordred["potion"]["effect"]:
mordred["power"] += mordred["potion"]["effect"]["power"]

if "protection" in mordred["potion"]["effect"]:
mordred["protection"] += mordred["potion"]["effect"]["protection"]

if "hp" in mordred["potion"]["effect"]:
mordred["hp"] += mordred["potion"]["effect"]["hp"]

# red_knight
red_knight = knightsConfig["red_knight"]

# apply armour
red_knight["protection"] = 0
for a in red_knight["armour"]:
red_knight["protection"] += a["protection"]

# apply weapon
red_knight["power"] += red_knight["weapon"]["power"]

# apply potion if exist
if red_knight["potion"] is not None:
if "power" in red_knight["potion"]["effect"]:
red_knight["power"] += red_knight["potion"]["effect"]["power"]

if "protection" in red_knight["potion"]["effect"]:
red_knight["protection"] += red_knight["potion"]["effect"]["protection"]

if "hp" in red_knight["potion"]["effect"]:
red_knight["hp"] += red_knight["potion"]["effect"]["hp"]

# -------------------------------------------------------------------------------
# BATTLE:

# 1 Lancelot vs Mordred:
lancelot["hp"] -= mordred["power"] - lancelot["protection"]
mordred["hp"] -= lancelot["power"] - mordred["protection"]

# check if someone fell in battle
if lancelot["hp"] <= 0:
lancelot["hp"] = 0

if mordred["hp"] <= 0:
mordred["hp"] = 0

# 2 Arthur vs Red Knight:
arthur["hp"] -= red_knight["power"] - arthur["protection"]
red_knight["hp"] -= arthur["power"] - red_knight["protection"]

# check if someone fell in battle
if arthur["hp"] <= 0:
arthur["hp"] = 0

if red_knight["hp"] <= 0:
red_knight["hp"] = 0

# Return battle results:
return {
lancelot["name"]: lancelot["hp"],
arthur["name"]: arthur["hp"],
mordred["name"]: mordred["hp"],
red_knight["name"]: red_knight["hp"],
}


print(battle(KNIGHTS))
if __name__ == "__main__":
result = battle(KNIGHTS)
print(result)
Empty file added app/models/__init__.py
View file
Open in desktop
Empty file.
4 changes: 4 additions & 0 deletions app/models/armour.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
class Armour:
def __init__(self, part: str, protection: int) -> None:
self.part = part
self.protection = protection
29 changes: 29 additions & 0 deletions app/models/knight.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
from app.models.armour import Armour
from app.models.weapon import Weapon
from app.models.potion import Potion


class Knight:

def __init__(self, name: str, power: int, hp: int,
armour: list, weapon: dict, potion: dict) -> None:
self.name = name
self.base_power = power
self.hp = hp
self.armour = [Armour(**a) for a in armour]
self.weapon = Weapon(**weapon)
self.potion = Potion(**potion) if potion else None
self.apply_equipment()

def apply_equipment(self) -> None:
self.protection = sum([a.protection for a in self.armour])
self.power = self.base_power + self.weapon.power
if self.potion:
self.hp += self.potion.effect.get("hp", 0)
self.power += self.potion.effect.get("power", 0)
self.protection += self.potion.effect.get("protection", 0)

def take_damage(self, damage: int) -> None:
self.hp -= max(0, damage - self.protection)
if self.hp < 0:
self.hp = 0
4 changes: 4 additions & 0 deletions app/models/potion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
class Potion:
def __init__(self, name: str, effect: dict) -> None:
self.name = name
self.effect = effect
4 changes: 4 additions & 0 deletions app/models/weapon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
class Weapon:
def __init__(self, name: str, power: int) -> None:
self.name = name
self.power = power
Loading