Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #772

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Develop #772

wants to merge 6 commits into from

Conversation

KKvladys
Copy link

@KKvladys KKvladys commented Dec 6, 2024

No description provided.

Copy link

@pohgen pohgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like some crucial files are missing from your submission, such as the Django project files and the cinema app files, which include the Movie model, serializer, and API views. These files are essential for verifying that your implementation meets the task requirements. Please include these files so we can complete the review. Keep up the good work, and once these files are added, we can proceed with the review! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: 7]

If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great effort on setting up the .gitignore and manage.py files! 🎉 However, there are a few critical areas that need your attention:

  1. Missing Django Project and App Files: The essential Django project files and the cinema app files, including the Movie model, serializer, and API views, are not present. These are crucial for verifying your implementation against the task requirements. Please ensure these files are included in your next submission.

  2. .gitignore File: You've done a good job with the .gitignore file, which is correctly set up to exclude unnecessary files like database files and compiled Python files.

The decision to approve is made to help you move forward with your learning journey. Please review the comments and address the issues to improve your code. Remember, addressing critical issues is essential to ensure the functionality of your project. Keep up the good work and continue learning from your experiences! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants