Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #774

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
.idea/
.vscode/
*.iml
.env
.DS_Store
venv/
.venv/
.pytest_cache/
**__pycache__/
cinema_service_db_data.json
db.sqlite3
.idea
Empty file added app/__init__.py
Empty file.
16 changes: 16 additions & 0 deletions app/asgi.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
"""
ASGI config for app project.

It exposes the ASGI callable as a module-level variable named ``application``.

For more information on this file, see
https://docs.djangoproject.com/en/5.1/howto/deployment/asgi/
"""

import os

from django.core.asgi import get_asgi_application

os.environ.setdefault("DJANGO_SETTINGS_MODULE", "app.settings")

application = get_asgi_application()
131 changes: 131 additions & 0 deletions app/settings.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,131 @@
"""
Django settings for app project.

Generated by 'django-admin startproject' using Django 5.1.4.

For more information on this file, see
https://docs.djangoproject.com/en/5.1/topics/settings/

For the full list of settings and their values, see
https://docs.djangoproject.com/en/5.1/ref/settings/
"""

from pathlib import Path

# Build paths inside the project like this: BASE_DIR / 'subdir'.
BASE_DIR = Path(__file__).resolve().parent.parent


# Quick-start development settings - unsuitable for production
# See https://docs.djangoproject.com/en/5.1/howto/deployment/checklist/

# SECURITY WARNING: keep the secret key used in production secret!
SECRET_KEY = ("django-insecure-y4=ar8*efb!bxot"
"#7c_@-3dt16)+77p5s7s2aadrwixv&e0z94")
Comment on lines +23 to +24

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SECRET_KEY should not be hardcoded in the settings file for security reasons. It's recommended to load it from an environment variable or a separate configuration file that is not included in version control.

Comment on lines +23 to +24

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SECRET_KEY is hardcoded. For security reasons, it's recommended to load it from an environment variable or a separate configuration file that is not included in version control.


# SECURITY WARNING: don't run with debug turned on in production!
DEBUG = True

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DEBUG setting is set to True. This should be set to False in a production environment to avoid exposing sensitive information.


ALLOWED_HOSTS = []

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ALLOWED_HOSTS list is empty. In a production environment, you should specify the domain names or IP addresses that your Django site can serve.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ALLOWED_HOSTS list is empty. In a production environment, you should specify the domain names or IP addresses that your Django site can serve.



# Application definition

INSTALLED_APPS = [
"django.contrib.admin",
"django.contrib.auth",
"django.contrib.contenttypes",
"django.contrib.sessions",
"django.contrib.messages",
"django.contrib.staticfiles",
"app",
"cinema",
"rest_framework",
]

MIDDLEWARE = [
"django.middleware.security.SecurityMiddleware",
"django.contrib.sessions.middleware.SessionMiddleware",
"django.middleware.common.CommonMiddleware",
"django.middleware.csrf.CsrfViewMiddleware",
"django.contrib.auth.middleware.AuthenticationMiddleware",
"django.contrib.messages.middleware.MessageMiddleware",
"django.middleware.clickjacking.XFrameOptionsMiddleware",
]

ROOT_URLCONF = "app.urls"

TEMPLATES = [
{
"BACKEND": "django.template.backends.django.DjangoTemplates",
"DIRS": [],
"APP_DIRS": True,
"OPTIONS": {
"context_processors": [
"django.template.context_processors.debug",
"django.template.context_processors.request",
"django.contrib.auth.context_processors.auth",
"django.contrib.messages.context_processors.messages",
],
},
},
]

WSGI_APPLICATION = "app.wsgi.application"


# Database
# https://docs.djangoproject.com/en/5.1/ref/settings/#databases

DATABASES = {
"default": {
"ENGINE": "django.db.backends.sqlite3",
"NAME": BASE_DIR / "db.sqlite3",
}
}


# Password validation
# https://docs.djangoproject.com/en/5.1/ref/settings/#auth-password-validators

AUTH_PASSWORD_VALIDATORS = [
{
"NAME": "django.contrib.auth.password_validation."
"UserAttributeSimilarityValidator",
},
{
"NAME": "django.contrib.auth.password_validation."
"MinimumLengthValidator",
},
{
"NAME": "django.contrib.auth.password_validation."
"CommonPasswordValidator",
},
{
"NAME": "django.contrib.auth.password_validation."
"NumericPasswordValidator",
},
]


# Internationalization
# https://docs.djangoproject.com/en/5.1/topics/i18n/

LANGUAGE_CODE = "en-us"

TIME_ZONE = "UTC"

USE_I18N = True

USE_TZ = True


# Static files (CSS, JavaScript, Images)
# https://docs.djangoproject.com/en/5.1/howto/static-files/

STATIC_URL = "static/"

# Default primary key field type
# https://docs.djangoproject.com/en/5.1/ref/settings/#default-auto-field

DEFAULT_AUTO_FIELD = "django.db.models.BigAutoField"
24 changes: 24 additions & 0 deletions app/urls.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
"""
URL configuration for app project.

The `urlpatterns` list routes URLs to views. For more information please see:
https://docs.djangoproject.com/en/5.1/topics/http/urls/
Examples:
Function views
1. Add an import: from my_app import views
2. Add a URL to urlpatterns: path('', views.home, name='home')
Class-based views
1. Add an import: from other_app.views import Home
2. Add a URL to urlpatterns: path('', Home.as_view(), name='home')
Including another URLconf
1. Import the include() function: from django.urls import include, path
2. Add a URL to urlpatterns: path('blog/', include('blog.urls'))
"""

from django.contrib import admin
from django.urls import path, include

urlpatterns = [
path("admin/", admin.site.urls),
path("api/cinema/", include("cinema.urls", namespace="cinema")),
]
16 changes: 16 additions & 0 deletions app/wsgi.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
"""
WSGI config for app project.

It exposes the WSGI callable as a module-level variable named ``application``.

For more information on this file, see
https://docs.djangoproject.com/en/5.1/howto/deployment/wsgi/
"""

import os

from django.core.wsgi import get_wsgi_application

os.environ.setdefault("DJANGO_SETTINGS_MODULE", "app.settings")

application = get_wsgi_application()
Empty file added cinema/__init__.py
Empty file.
3 changes: 3 additions & 0 deletions cinema/admin.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
from django.contrib import admin

# Register your models here.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider registering the Movie model with the admin site to manage it through the Django admin interface. You can do this by importing the Movie model and using admin.site.register(Movie).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Movie model is not registered with the Django admin site. Consider adding admin.site.register(Movie) to manage the model through the admin interface. Make sure to import the Movie model from cinema.models.

6 changes: 6 additions & 0 deletions cinema/apps.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
from django.apps import AppConfig


class CinemaConfig(AppConfig):
default_auto_field = "django.db.models.BigAutoField"
name = "cinema"
30 changes: 30 additions & 0 deletions cinema/migrations/0001_initial.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
# Generated by Django 4.2 on 2024-12-07 07:45

from django.db import migrations, models


class Migration(migrations.Migration):

initial = True

dependencies = []

operations = [
migrations.CreateModel(
name="Movie",
fields=[
(
"id",
models.BigAutoField(
auto_created=True,
primary_key=True,
serialize=False,
verbose_name="ID",
),
),
("title", models.CharField(max_length=255)),
("description", models.TextField()),
("duration", models.IntegerField()),
],
),
]
Empty file added cinema/migrations/__init__.py
Empty file.
11 changes: 11 additions & 0 deletions cinema/models.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
from django.db import models


# Create your models here.
class Movie(models.Model):
title = models.CharField(max_length=255)
description = models.TextField()
duration = models.IntegerField()

def __str__(self):
return self.title
20 changes: 20 additions & 0 deletions cinema/serializers.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
from rest_framework import serializers

from cinema.models import Movie


class MovieSerializer(serializers.Serializer):
id = serializers.IntegerField(read_only=True)
title = serializers.CharField(max_length=55)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title field in the serializer has a max_length of 55, which is inconsistent with the max_length of 255 in the Movie model. Consider updating the serializer to match the model's max_length.

description = serializers.CharField(max_length=255)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description field in the serializer has a max_length of 255, but the Movie model uses a TextField, which does not have a max_length restriction. Consider removing the max_length constraint from the serializer or adjusting it to reflect any intended limits.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description field in the serializer has a max_length of 255, which is inconsistent with the TextField used in the Movie model. Consider removing the max_length constraint from the serializer or adjusting it to reflect any intended limits.

duration = serializers.IntegerField()

def create(self, validated_date):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the method parameter validated_date. It should be validated_data to match the standard naming convention.

return Movie.objects.create(**validated_date)

def update(self, instance, validated_data):
instance.title = validated_data.get("title", instance.title)
instance.description = validated_data.get("description", instance.description)
instance.duration = validated_data.get("duration", instance.duration)
instance.save()
return instance
3 changes: 3 additions & 0 deletions cinema/tests.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
from django.test import TestCase

# Create your tests here.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding test cases to this file to verify the functionality of your Movie model and any views or serializers you have implemented. This will help ensure the reliability and correctness of your application.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests.py file is empty. Consider adding test cases for the Movie model, views, and serializers to ensure the application's reliability and correctness.

10 changes: 10 additions & 0 deletions cinema/urls.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
from django.urls import path

from cinema.views import movie_list, movie_detail

app_name = "cinema"

urlpatterns = [
path("movies/", movie_list, name="movie-list"),
path("movies/<int:pk>/", movie_detail, name="movie-detail"),
]
38 changes: 38 additions & 0 deletions cinema/views.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
from django.shortcuts import get_object_or_404
from rest_framework.decorators import api_view
from rest_framework.response import Response
from rest_framework import status

from cinema.models import Movie
from cinema.serializers import MovieSerializer


# Create your views here.
@api_view(["GET", "POST"])
def movie_list(request) -> Response:
if request.method == "GET":
movies = Movie.objects.all()
serializer = MovieSerializer(movies, many=True)
return Response(serializer.data, status=status.HTTP_200_OK)
else:
serializer = MovieSerializer(data=request.data)
serializer.is_valid(raise_exception=True)
serializer.save()
return Response(serializer.data, status=status.HTTP_201_CREATED)


@api_view(["GET", "PUT", "DELETE"])
def movie_detail(request, pk: int) -> Response:
movie = get_object_or_404(Movie, id=pk)
if request.method == "GET":
movie = get_object_or_404(Movie, id=pk)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The get_object_or_404 call is redundant here since movie is already retrieved at the beginning of the movie_detail function. You can remove this line to avoid unnecessary database queries.

Comment on lines +26 to +28

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a redundant get_object_or_404 call in the movie_detail function. The movie object is already retrieved on line 26, so the call on line 28 is unnecessary and can be removed to avoid redundant database queries.

serializer = MovieSerializer(movie)
return Response(serializer.data, status=status.HTTP_200_OK)
elif request.method == "PUT":
serializer = MovieSerializer(movie, data=request.data)
serializer.is_valid(raise_exception=True)
serializer.save()
return Response(serializer.data, status=status.HTTP_200_OK)
else:
movie.delete()
return Response(status=status.HTTP_204_NO_CONTENT)
22 changes: 22 additions & 0 deletions manage.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
#!/usr/bin/env python
"""Django's command-line utility for administrative tasks."""
import os
import sys


def main():
"""Run administrative tasks."""
os.environ.setdefault('DJANGO_SETTINGS_MODULE', 'app.settings')
try:
from django.core.management import execute_from_command_line
except ImportError as exc:
raise ImportError(
"Couldn't import Django. Are you sure it's installed and "
"available on your PYTHONPATH environment variable? Did you "
"forget to activate a virtual environment?"
) from exc
execute_from_command_line(sys.argv)


if __name__ == '__main__':
main()