Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #681

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

solution #681

wants to merge 1 commit into from

Conversation

Bombardier256
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the task requirements! 🎉 Your code is well-structured and meets the core functionality as described. The use of classes and methods is effective, and the logic for calculating trip costs is spot on. While there's a minor suggestion regarding the bill method in the Shop class, it doesn't impact the overall functionality. Keep up the good work, and consider enhancing the error handling for even better clarity in the future! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +21 to +22
print(product, "not in stack")
return 0, 0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bill method returns (0, 0) if a product is not in stock. This might not be the best approach, as it doesn't provide a clear indication of the issue to the caller. Consider raising an exception or returning a more informative result to indicate that the order couldn't be fulfilled due to missing products.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants