Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Luau and Roblox ecosystem icons #1560

Merged
merged 28 commits into from
Nov 4, 2024
Merged

feat: Add Luau and Roblox ecosystem icons #1560

merged 28 commits into from
Nov 4, 2024

Conversation

Synthetic-Dev
Copy link
Contributor

@Synthetic-Dev Synthetic-Dev commented Jun 11, 2022 •
edited
Loading

Added Luau file format, file icon and folder icons
Added Roblox file formats and file icon + file icons and definitions for common Roblox tools: Rojo and Wally

@Synthetic-Dev Synthetic-Dev marked this pull request as ready for review June 11, 2022 18:44
@Synthetic-Dev
Copy link
Contributor Author

image

@Synthetic-Dev Synthetic-Dev marked this pull request as draft September 19, 2022 15:35
@Synthetic-Dev Synthetic-Dev marked this pull request as ready for review September 19, 2022 15:36
@Synthetic-Dev Synthetic-Dev changed the title Add Luau and Roblox ecosystem icons feat: Add Luau and Roblox ecosystem icons Feb 3, 2023
@TreehouseFalcon
Copy link

Bumping this PR, to the maintainers: is there anything else that needs to be done to have this merged?

@Synthetic-Dev
Copy link
Contributor Author

Luau lettering removed from the luau icons, added rbxmk tool icon and updated entries.

@Synthetic-Dev
Copy link
Contributor Author

@PKief please review.

@PKief PKief force-pushed the main branch 3 times, most recently from 640fb8a to d5912bb Compare November 18, 2023 10:30
@TreehouseFalcon
Copy link

TreehouseFalcon commented Nov 28, 2023 •
edited
Loading

Hi @PKief, are there any outstanding issues that need to be fixed here? I'd love to be able to use these icons.

@PKief PKief force-pushed the main branch 2 times, most recently from eeb4f0e to b2e0fe4 Compare June 12, 2024 20:23
@github-actions github-actions bot added the icons PR with new icons label Oct 30, 2024
@lucas-labs

This comment was marked as outdated.

Sign in to view
lucas-labs
lucas-labs reviewed Oct 31, 2024
View reviewed changes
icons/folder-luau-open.svg Outdated Show resolved Hide resolved
icons/luau.svg Outdated Show resolved Hide resolved
icons/rbxmk.svg Outdated Show resolved Hide resolved
icons/rojo.svg Outdated Show resolved Hide resolved
icons/wally.svg Outdated Show resolved Hide resolved
src/core/icons/fileIcons.ts Show resolved Hide resolved
@Synthetic-Dev
Copy link
Contributor Author

Hi @lucas-labs

Thanks for the review, I'll take a look at the workflows and fix the issues you mentioned, will @ to let you know when everything is passing!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024 •
edited
Loading

Preview

Thank you for creating a pull request. This preview shows you how your icons will look on the different themes:

Generated preview

Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

@okineadev
Copy link
Contributor

[luau.svg] Invalid color #00A2FF. Suggestions: [#42A5F5, #039BE5, #03A9F4, #2196F3, #00B0FF]
[luau.svg] Invalid color white. Suggestions: [#FAFAFA, #F5F5F5, #EEEEEE, #ECEFF1, #EFEBE9]
[rbxmk.svg] Invalid color #13BD2A. Suggestions: [#00C853, #4CAF50, #66BB6A, #7CB342, #43A047]
[rojo.svg] Invalid color #E13835. Suggestions: [#E53935, #D32F2F, #F44336, #FF1744, #EF5350]
[wally.svg] Invalid color #F2C57E. Suggestions: [#FFCC80, #FFD180, #FFB74D, #FFE0B2, #FFE082]
[wally.svg] Invalid color #BD704B. Suggestions: [#E65100, #E64A19, #D84315, #F4511E, #EF6C00]
[wally.svg] Invalid color #AD4646. Suggestions: [#C62828, #D32F2F, #B71C1C, #E53935, #C2185B]
[wally.svg] Invalid color #3F2418. Suggestions: [#3E2723, #4E342E, #5D4037, #6D4C41, #212121]

@github-actions github-actions bot added the translations Issues related to translating the project into other languages label Nov 1, 2024
@Synthetic-Dev
Copy link
Contributor Author

Hey @lucas-labs

Please re-review.

@lucas-labs

This comment was marked as outdated.

Sign in to view
@lucas-labs lucas-labs self-requested a review November 2, 2024 02:01
lucas-labs
lucas-labs approved these changes Nov 3, 2024
View reviewed changes
Copy link
Member

@lucas-labs lucas-labs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a 1px margin (read reason here), and fixed the failing CI.

I think it looks better now without the circle around the icon.

In general, LGTM. Let's wait for pkief's thoughts.

@lucas-labs lucas-labs requested a review from PKief November 3, 2024 03:27
@PKief
Copy link
Member

PKief commented Nov 4, 2024

lgtm as well 👍 Thanks for the contribution.

@PKief PKief merged commit 073f704 into material-extensions:main Nov 4, 2024
4 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the Marketplace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PKief PKief PKief approved these changes

@lucas-labs lucas-labs lucas-labs approved these changes

Assignees
No one assigned
Labels
icons PR with new icons translations Issues related to translating the project into other languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Synthetic-Dev @TreehouseFalcon @AdamRaichu @lucas-labs @okineadev @PKief