-
-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added freemarker icon #2396
Added freemarker icon #2396
Conversation
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information on how to contribute in the contribution guidelines. |
Signed-off-by: Okinea Dev <[email protected]>
@okineadev can you please check if there's the possibility to make this icon fit into a 16x16 grid to improve its visual quality? Please have a look at the contribution guidelines under the point "Designing Pixel-Perfect icons". |
@coderabbitai Place this icon in a 16x16 grid and make it pixel-perfect (fit the corners of the icon to the grid) |
Tip For best results, initiate chat on the files or code changes. @okineadev: The Analysis chainScripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Locate the freemarker icon file in the repository
fd -e svg -e png -e ico -e jpg --type f --search-path . --glob '*freemarker*'
# Display the contribution guidelines for designing pixel-perfect icons
rg -A 5 "Designing Pixel-Perfect icons" --markdown
Length of output: 568 Script: #!/bin/bash
# Correct the command to search for the contribution guidelines related to designing pixel-perfect icons
rg -A 5 "Designing Pixel-Perfect icons"
Length of output: 41 |
PreviewThank you for creating a pull request. This preview shows you how your icon will look on the different themes: Check how your icon fits in a 16x16 grid with our Pixel Perfect Checker by following this link. You can find more information on how to contribute in the contribution guidelines. |
@okineadev can you resolve the merge conflict? |
No |
@okineadev you don't have access to the CLI at the moment? I can take a look later, even for me the button is disabled. |
Merge SuccessfulThanks for your contribution! 🎉 The changes will be part of the upcoming update on the Marketplace. |
Closes #2356