Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added freemarker icon #2396

Merged
merged 5 commits into from
Sep 4, 2024
Merged

Conversation

okineadev
Copy link
Contributor

Closes #2356

Copy link
Contributor

github-actions bot commented Jul 6, 2024

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated preview

You can find more information on how to contribute in the contribution guidelines.

@okineadev
Copy link
Contributor Author

@PKief

@PKief
Copy link
Member

PKief commented Jul 8, 2024

@okineadev can you please check if there's the possibility to make this icon fit into a 16x16 grid to improve its visual quality? Please have a look at the contribution guidelines under the point "Designing Pixel-Perfect icons".

@okineadev okineadev marked this pull request as draft July 10, 2024 04:18
@okineadev
Copy link
Contributor Author

@coderabbitai Place this icon in a 16x16 grid and make it pixel-perfect (fit the corners of the icon to the grid)

Copy link

coderabbitai bot commented Aug 11, 2024

Tip

For best results, initiate chat on the files or code changes.

@okineadev: The freemarker.svg icon file has been located in the repository. However, I couldn't find specific guidelines for designing pixel-perfect icons in the repository. To proceed, you should adjust the icon to fit within a 16x16 grid using a vector graphics editor like Adobe Illustrator or Inkscape. Ensure that the corners of the icon align with the grid to maintain visual clarity and quality. If there are specific guidelines you have in mind, please provide them, and I'll assist further.

Analysis chain
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Locate the freemarker icon file in the repository
fd -e svg -e png -e ico -e jpg --type f --search-path . --glob '*freemarker*'
# Display the contribution guidelines for designing pixel-perfect icons
rg -A 5 "Designing Pixel-Perfect icons" --markdown

Length of output: 568


Script:

#!/bin/bash
# Correct the command to search for the contribution guidelines related to designing pixel-perfect icons
rg -A 5 "Designing Pixel-Perfect icons"

Length of output: 41

@github-actions github-actions bot added the icons PR with new icons label Aug 31, 2024
Copy link
Contributor

github-actions bot commented Aug 31, 2024

Preview

Thank you for creating a pull request. This preview shows you how your icon will look on the different themes:

Generated preview

Check how your icon fits in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

@okineadev
Copy link
Contributor Author

okineadev commented Aug 31, 2024

Looks dumb

@okineadev okineadev marked this pull request as ready for review August 31, 2024 18:16
@okineadev
Copy link
Contributor Author

@PKief

@PKief
Copy link
Member

PKief commented Sep 3, 2024

@okineadev can you resolve the merge conflict?

@okineadev
Copy link
Contributor Author

@okineadev can you resolve the merge conflict?

No

Screenshot_2024-09-03-12-55-13-797_com android chrome

@PKief
Copy link
Member

PKief commented Sep 3, 2024

@okineadev you don't have access to the CLI at the moment?

image

I can take a look later, even for me the button is disabled.

@okineadev
Copy link
Contributor Author

Am I the only one who thinks the icon is moving to the left?

image

@PKief PKief merged commit 36abc30 into material-extensions:main Sep 4, 2024
4 checks passed
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the Marketplace.

@okineadev okineadev deleted the freemaker-icon branch September 4, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons PR with new icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Icon Request] <FreeMarker>
2 participants