Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add folder icons for element and elements folders #2526

Merged
merged 5 commits into from
Nov 8, 2024
Merged

feat: add folder icons for element and elements folders #2526

merged 5 commits into from
Nov 8, 2024

Conversation

MTtankkeo
Copy link
Contributor

Description

Added new folder-icon for element, elements about user interface.

Contribution Guidelines

@github-actions github-actions bot added the 🏞️ icons PR with new icons label Aug 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 8, 2024 •
edited
Loading

Preview

Thank you for creating a pull request. This preview shows you how your icons will look on the different themes:

Generated preview

Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

@okineadev
Copy link
Contributor

Screenshot_2024-08-10-20-35-41-054_com.android.chrome.jpg

@MTtankkeo The icon looks a little bad on a white background

@MTtankkeo
Copy link
Contributor Author

Oh, I'll change the color of the icon.

@MTtankkeo
Copy link
Contributor Author

Hmm, will I just change the icon shape because It's hard to choose the right color because of the color palette?

@okineadev
Copy link
Contributor

Hmm, will I just change the icon shape because It's hard to choose the right color because of the color palette?

Try it

TheCukitoDev
TheCukitoDev approved these changes Aug 29, 2024
View reviewed changes
Copy link

@TheCukitoDev TheCukitoDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is cool. Has my aprove. I checked pixel-perfect

@PKief PKief force-pushed the main branch 2 times, most recently from ed9ed26 to 55e5e9c Compare September 20, 2024 19:17
@material-extensions material-extensions deleted a comment from coderabbitai bot Oct 30, 2024
@material-extensions material-extensions deleted a comment from coderabbitai bot Oct 30, 2024
@okineadev okineadev requested a review from Copilot November 4, 2024 17:10
Copilot
Copilot AI reviewed Nov 4, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no suggestions.
@okineadev okineadev changed the title Added folder-icon for element, elements. feat: add folder icons for element, and elements folders Nov 6, 2024
@okineadev okineadev changed the title feat: add folder icons for element, and elements folders feat: add folder icons for element and elements folders Nov 6, 2024
@PKief PKief merged commit 05ff80a into material-extensions:main Nov 8, 2024
4 of 5 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the Marketplace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@TheCukitoDev TheCukitoDev TheCukitoDev approved these changes

@PKief PKief PKief approved these changes

Assignees
No one assigned
Labels
🏞️ icons PR with new icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MTtankkeo @okineadev @PKief @TheCukitoDev