Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): add useful comments and update issue templates #2643

Merged
merged 1 commit into from
Oct 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# See https://git-scm.com/docs/gitattributes#_pattern_format for more about `.gitattributes`.

# Normalize EOL for all files that Git considers text files
* text=auto eol=lf

Expand Down
4 changes: 3 additions & 1 deletion .github/ISSUE_TEMPLATE/1-icon-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@ body:
id: graphic-ideas
attributes:
label: Graphic ideas
description: A clear description of the icon you would like. If the icons are separate for folder and files, please create separate issues.
description: |
A clear description of the icon you would like.
If the icons are separate for folder and files, please create separate issues.
placeholder: Include a link to sample icons if possible

- type: textarea
Expand Down
8 changes: 4 additions & 4 deletions .github/ISSUE_TEMPLATE/2-bug-report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ body:
id: description
attributes:
label: Describe the bug
description: Describe the bug clearly
description: Provide a detailed description of the bug
validations:
required: true

Expand All @@ -34,15 +34,15 @@ body:
id: expected
attributes:
label: Expected behavior
description: A clear and concise description of what you expected to happen
description: What you expected to happen
validations:
required: true

- type: textarea
id: screenshots
attributes:
label: Screenshots
description: If applicable, add screenshots to help explain your problem
description: Add screenshots if applicable
validations:
required: false

Expand All @@ -64,7 +64,7 @@ body:
id: additional-context
attributes:
label: Additional context
description: Add any other context about the problem here.
description: Additional context about the problem.
validations:
required: false

Expand Down
19 changes: 19 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
# See https://git-scm.com/docs/gitignore#_pattern_format for more about ignoring files.

# Ignore build output directories
out
dist

# Ignore node_modules directory
node_modules

# Ignore VS Code test files
.vscode-test/**
*.vsix

# Ignore specific icon files and directories
icons/file.svg
icons/folder.svg
icons/folder-open.svg
Expand All @@ -14,5 +20,18 @@ icons/folder-root-open.svg
icons/*.clone.svg
icons/clones

# Ignore specific HTML files in scripts directories
src/scripts/preview/*.html
src/scripts/contributors/*.html

# Ignore cache directory
.cache

# Ignore log files
*.log

# Ignore optional eslint cache
.eslintcache

*.tgz
*.tgz
5 changes: 5 additions & 0 deletions .vscodeignore
Original file line number Diff line number Diff line change
@@ -1,18 +1,23 @@
# Files to include in the extension package
# Documentation for this format:
# https://code.visualstudio.com/api/working-with-extensions/publishing-extension#using-.vscodeignore

# Files for vscode extension
!CHANGELOG.md
!LICENSE.md
!README.md
!logo.png

# Translation files
!package.json
!package.nls.json
!package.nls.*.json

# Extension code
!dist/extension
!dist/material-icons.json

# Icons
!icons

# Exclude everything else
Expand Down
10 changes: 8 additions & 2 deletions material-colors.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# This YAML file contains a list of color codes used in the VSCode Material Icon Theme.
# Each color is represented by its hexadecimal code and is categorized by its color name and shade.

# Note:
# - Black (`#000000`) and White (`#FFFFFF`) cannot not be used.

colors:
- '#FFEBEE' # red 50
- '#FFCDD2' # red 100
Expand Down Expand Up @@ -253,5 +259,5 @@ colors:
- '#455A64' # blue gray 700
- '#37474F' # blue gray 800
- '#263238' # blue gray 900
# - '#000000' # black must not be used
# - '#FFFFFF' # white must not be used
# - '#000000' # black must not be used
# - '#FFFFFF' # white must not be used
8 changes: 7 additions & 1 deletion svgo.config.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
module.exports = {
/**
* @typedef {import('svgo').Config} SVGOConfig
* @typedef {import('svgo').PluginConfig} PluginConfig
*/

module.exports = /** @type {SVGOConfig} */ {
multipass: true,
precision: 2,
/** @type {PluginConfig[]} */
plugins: [
{
name: 'preset-default',
Expand Down