Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ci): ♻️ organize the structure of workflows #2799

Merged
merged 6 commits into from
Jan 11, 2025

Conversation

okineadev
Copy link
Member

Description

...and make clear the names of the steps in workflows

  • Moved permissions to the top for a better structure, besides there is no point in setting permissions inside steps, because we only use one step in the workflow, so it is allowed to apply permissions globally.
  • Streamlined the structure of GitHub Workflows
  • Modified funding configuration format for GitHub.
  • Cleaned up unnecessary comments and improved overall readability.

Contribution Guidelines

…he steps in workflows

* Moved `permissions` to the top for a better structure, besides there is no point in setting `permissions` inside `steps`, because we only use one step in the workflow, so it is allowed to apply `permissions` globally.
* Streamlined the structure of GitHub Workflows
* Modified funding configuration format for GitHub.
* Cleaned up unnecessary comments and improved overall readability.
@okineadev okineadev requested a review from Copilot January 9, 2025 10:38
@github-actions github-actions bot added the 🔄 workflows GitHub Actions label Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 11 changed files in this pull request and generated no comments.

Files not reviewed (6)
  • .github/labeler.yml: Evaluated as low risk
  • .github/workflows/pr-closed.yml: Evaluated as low risk
  • .github/workflows/label.yml: Evaluated as low risk
  • .github/workflows/pr-title.yml: Evaluated as low risk
  • .github/workflows/release.yml: Evaluated as low risk
  • .github/FUNDING.yml: Evaluated as low risk
* Adjusted the formatting of the merge success message in the PR closed workflow.
* Improved readability by adding a newline before the message body.
.github/workflows/label.yml Outdated Show resolved Hide resolved
@okineadev okineadev requested a review from PKief January 10, 2025 13:10
@okineadev okineadev marked this pull request as draft January 10, 2025 16:36
@okineadev okineadev marked this pull request as ready for review January 10, 2025 16:51
@PKief PKief merged commit 25d52f2 into main Jan 11, 2025
1 check passed
@PKief PKief deleted the organize-the-structure-of-workflows branch January 11, 2025 10:53
Copy link
Contributor

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the Marketplace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔄 workflows GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants