-
-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ci): ♻️ organize the structure of workflows #2799
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he steps in workflows * Moved `permissions` to the top for a better structure, besides there is no point in setting `permissions` inside `steps`, because we only use one step in the workflow, so it is allowed to apply `permissions` globally. * Streamlined the structure of GitHub Workflows * Modified funding configuration format for GitHub. * Cleaned up unnecessary comments and improved overall readability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 11 changed files in this pull request and generated no comments.
Files not reviewed (6)
- .github/labeler.yml: Evaluated as low risk
- .github/workflows/pr-closed.yml: Evaluated as low risk
- .github/workflows/label.yml: Evaluated as low risk
- .github/workflows/pr-title.yml: Evaluated as low risk
- .github/workflows/release.yml: Evaluated as low risk
- .github/FUNDING.yml: Evaluated as low risk
* Adjusted the formatting of the merge success message in the PR closed workflow. * Improved readability by adding a newline before the message body.
PKief
reviewed
Jan 10, 2025
PKief
reviewed
Jan 10, 2025
PKief
reviewed
Jan 10, 2025
…e of the extension file
PKief
approved these changes
Jan 11, 2025
Merge SuccessfulThanks for your contribution! 🎉 The changes will be part of the upcoming update on the Marketplace. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
...and make clear the names of the steps in workflows
permissions
to the top for a better structure, besides there is no point in settingpermissions
insidesteps
, because we only use one step in the workflow, so it is allowed to applypermissions
globally.Contribution Guidelines