-
-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update unity icon #2827
feat: update unity icon #2827
Conversation
1d94384
to
abfe9ca
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
PreviewThank you for creating a pull request. This preview shows you how your icons will look on the different themes: Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link. You can find more information on how to contribute in the contribution guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd love to see these icons more colorful. That's the identity of this icon theme. You'll find most of the icons in a bright and colorful tone. Please adjust the icons to make us considering merging the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is better to leave the colors from the old icon (blue), there is better contrast
It's a better contrast, but it was outside the range of folder colors; though I can darken the folder by one level & reuse the standalone icon |
Maybe it would be better to make the file icon black and white? |
|
#I saw this, but the Unity icon is gray by itself |
It's just that the current icon is strongly associated with 3D and Devcontainers |
yeah but however, it's better if the icons are colorful. We usually prefer that before using grey and dark colors. Let's call it artistic freedom of this extension. It worked for most icons and made it so popular. |
Then you can merge this PR |
Merge SuccessfulThanks for your contribution! 🎉 The changes will be part of the upcoming update on the Marketplace. |
Description
Updates the Unity icons to represent their modern logo. Renamed filetype
shaderlab
tounity
;shaderlab
language is now part ofshaders
.Contribution Guidelines