Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update unity icon #2827

Merged
merged 10 commits into from
Jan 23, 2025
Merged

feat: update unity icon #2827

merged 10 commits into from
Jan 23, 2025

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Jan 19, 2025

Description

Updates the Unity icons to represent their modern logo. Renamed filetype shaderlab to unity; shaderlab language is now part of shaders.

Contribution Guidelines

@github-actions github-actions bot added the icons PR with new icons label Jan 19, 2025
@Repiteo Repiteo force-pushed the unity branch 2 times, most recently from 1d94384 to abfe9ca Compare January 19, 2025 17:25
@github-actions github-actions bot added the workflows GitHub Actions label Jan 20, 2025
@okineadev okineadev removed the workflows GitHub Actions label Jan 20, 2025
@okineadev

This comment was marked as off-topic.

Copy link
Contributor

github-actions bot commented Jan 21, 2025

Preview

Thank you for creating a pull request. This preview shows you how your icons will look on the different themes:

Generated preview

Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

PKief
PKief previously requested changes Jan 21, 2025
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to see these icons more colorful. That's the identity of this icon theme. You'll find most of the icons in a bright and colorful tone. Please adjust the icons to make us considering merging the changes.

https://github.com/material-extensions/vscode-material-icon-theme/blob/main/CONTRIBUTING.md#use-material-design-colors

Copy link
Contributor

@okineadev okineadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to leave the colors from the old icon (blue), there is better contrast

@Repiteo
Copy link
Contributor Author

Repiteo commented Jan 21, 2025

It's a better contrast, but it was outside the range of folder colors; though I can darken the folder by one level & reuse the standalone icon

icons/unity.svg Outdated Show resolved Hide resolved
icons/unity.svg Outdated Show resolved Hide resolved
@okineadev
Copy link
Contributor

Maybe it would be better to make the file icon black and white?

@PKief
Copy link
Member

PKief commented Jan 23, 2025

Maybe it would be better to make the file icon black and white?

#2827 (review)

@okineadev
Copy link
Contributor

Maybe it would be better to make the file icon black and white?

#2827 (review)

#I saw this, but the Unity icon is gray by itself

@okineadev
Copy link
Contributor

It's just that the current icon is strongly associated with 3D and Devcontainers

@PKief
Copy link
Member

PKief commented Jan 23, 2025

Maybe it would be better to make the file icon black and white?

#2827 (review)

#I saw this, but the Unity icon is gray by itself

yeah but however, it's better if the icons are colorful. We usually prefer that before using grey and dark colors. Let's call it artistic freedom of this extension. It worked for most icons and made it so popular.

@okineadev
Copy link
Contributor

Then you can merge this PR

@PKief PKief merged commit 9e25232 into material-extensions:main Jan 23, 2025
4 checks passed
Copy link
Contributor

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the Marketplace.

@Repiteo Repiteo deleted the unity branch January 25, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons PR with new icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants