feat(ci): 🔖 add labels to PRs and use reusable workflows #2829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
okineadev
added a commit
to material-extensions/workflows
that referenced
this pull request
Jan 20, 2025
Needed for material-extensions/vscode-material-icon-theme#2829 because it uses a separate workflow for adding labels Signed-off-by: Okinea Dev <[email protected]>
|
|
When this is done I will be able to test |
* Removed `contents: read` permission from the `pr-closed.yml` workflow.
okineadev
commented
Jan 23, 2025
Signed-off-by: Okinea Dev <[email protected]>
PKief
reviewed
Jan 26, 2025
There was a problem hiding this comment.
At the moment there's no capacity to elaborate on workflow files. We already had some additional effort in the past to fix failed workflow files. It makes the maintenance of the project more cumbersome and I want to avoid that. That's why the plans for adding labels automatically are stopped now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This approach uses an isolated environment for validations and a privileged environment for tagging, which ensures security
Contribution Guidelines