Conversation
|
The CL tools can't recognize generated files, so here's the svg outputs: file
folder
folder-open
folder-root
folder-root-open
|
Repiteo
force-pushed
the
16×16-generated
branch
3 times, most recently
from
3c70591 to
03d947d
Compare
Repiteo
force-pushed
the
16×16-generated
branch
from
03d947d to
556b912
Compare
…material-icon-theme into pr/Repiteo/2837
| @@ -238,11 +238,11 @@ export const generateFileIcons = async ( | |||
| } | |||
|
|
|||
| const fileIcon = | |||
| 'M13 9h5.5L13 3.5V9M6 2h8l6 6v12a2 2 0 0 1-2 2H6a2 2 0 0 1-2-2V4c0-1.11.89-2 2-2m5 2H6v16h12v-9h-7V4z'; | |||
| 'M9 2v3h3Zm4 2.5V14q0 1-1 1H4q-1 0-1-1V2q0-1 1-1h5.5ZM8 2H4v12h8V6H8Z'; | |||
There was a problem hiding this comment.
We can't merge this yet, because it will introduce an inconsistency with the other "file" icons which look simiar:
(image is not covering all cases...)
It may sound like perfectionism because it's hard to make out, but I'd prefer consistency over pixel perfectness. If someone has time to bring all files into the same format then we can talk about this, but I'm not feeling comfortable of merging the default file icon with a different shape to the other icons. Sorry for bringing this up so late, but I just noticed it while testing.
There was a problem hiding this comment.
Technically the original icon WAS pixel-perfect, it was just 24×24. If that's not a problem (or if it's even preferred), I would STRONGLY suggest making the acceptable dimensions explicit in the guidelines; right now it feels like 16×16 or bust
There was a problem hiding this comment.
24x24 Pixel perfectness will slightly suffer because VS Code renders the icons with 16x16 pixels. That's mentioned in our contribution guidelines.
However, even if it's not pixel perfect for 16x16 pixels it's not such a big problem. The icons are still nice and good to recognize. They can look a little bit blurry then but it's hard to make out the difference. So 24x24 pixel perfectness is still better than no pixel perfectness at all 😅
In general we highly recommend the 16x16 rule for new icons which we create and wherever it's possible. Or to say it in other words: It's more likely to get approval from us. Otherwise we have to evaluate if it's worth adding the icon.
In this case I'd recommend to keep it as it is. Don't spend too much time and energy on that, because we would have to change multiple icons to have the same file icon shape.
Description
Converts all generated icons to a 16×16 format with pixel-perfect points, matching the updated contribution guidelines.
Contribution Guidelines