chore: integrate minor .vscode/ tweaks
#2857
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PKief
reviewed
Jan 26, 2025
.vscode/launch.json
Outdated
| @@ -15,7 +15,7 @@ | |||
| }, | |||
| { | |||
| "name": "Run Web Extension in VS Code", | |||
| "type": "pwa-extensionHost", | |||
| "type": "extensionHost", | |||
There was a problem hiding this comment.
I was wondering if you can show a link if it's not required anymore? In their documentation I can still find a reference where they are using it. That's why I'm a little bit confused now:
https://code.visualstudio.com/api/extension-guides/web-extensions#test-your-web-extension-in-vs-code-running-on-desktop
There was a problem hiding this comment.
Huh! I was tipped off by intellisense saying it was invalid, but that's indeed the syntax shown in the example. Gonna revert that change; if I find anything concrete, I'll propose it in a separate PR
Repiteo
force-pushed
the
vscode-tweaks
branch
from
27f54d9 to
b99bfc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses a few straggler issues in the
.vscode/files:pwa-extensionHostreplaced withextensionHost, as the former was an experimental monicker that's no longer required.jock.svgset as svg formatter, because otherwise we're just recommending that extension for no real reason.Contribution Guidelines