Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add folder icons for freebsd, netbsd and puredarwin #2860

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Murateba
Copy link
Contributor

Description

Add new folder icons

  • folder-freebsd.svg for freebsd, bsd
  • folder-netbsd.svg for netbsd
  • folder-darwin.svg for puredarwin, darwin

Contribution Guidelines

@github-actions github-actions bot added the icons PR with new icons label Jan 27, 2025
Copy link
Contributor

github-actions bot commented Jan 27, 2025

Preview

Thank you for creating a pull request. This preview shows you how your icons will look on the different themes:

Generated preview

Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

@lucas-labs
Copy link
Member

lucas-labs commented Jan 28, 2025

Thanks for the PR!

Just a small note: This icon pack usually prefer a 2 colors scheme for folder icons.

Where the motive and the background colors are chosen fom the following rows:

Expand Palette From https://pkief.github.io/material-color-converter/

I can see you're using colors from the last row (I think). This makes the icon looks ok in most light themes, but it can make it impossible to see in some dark themes.

Imagine someone uses this theme (I know, I know, but let's suppose for a second that such a person exists):

image

The freebds icon wouldn't work at all there. That's why we use half-toned colors. They usually work fine in virtually all themes, dark and light.

image

You can read more here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons PR with new icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants