Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract version values to global configuration flags. #10

Merged
merged 1 commit into from
Jan 23, 2019
Merged

Conversation

jverkoey
Copy link
Contributor

This is intended to make it easier to understand what needs to change when a version of a given tool needs to be updated.

This is intended to make it easier to understand what needs to change when a version of a given tool needs to be updated.
@jverkoey
Copy link
Contributor Author

jverkoey commented Jan 23, 2019

This is reopened from #9 but on the main repo so that Travis can run CI with the environment variables.

@romoore
Copy link

romoore commented Jan 23, 2019

I don't see any "secure environment variables" in this change - can you clarify why you abandoned the earlier PR?

@jverkoey jverkoey merged commit 9dac3fd into develop Jan 23, 2019
@jverkoey jverkoey deleted the vars branch January 23, 2019 19:15
@jverkoey
Copy link
Contributor Author

Encrypted environment variables are not available to pull requests from forks due to the security risk of exposing such information to unknown code.

https://docs.travis-ci.com/user/environment-variables/#defining-encrypted-variables-in-travisyml

@romoore
Copy link

romoore commented Jan 23, 2019

Sorry, I don't think that helps. I still don't get how if it's "encrypted" it can be unencrypted when a PR comes in from the same repo but not from a fork. Does that mean that we'll NEVER be able to submit PRs to this repo from a fork?

@romoore
Copy link

romoore commented Jan 23, 2019

Since your PR didn't modify any of those variables, it seems like Travis is broken - it can't run presubmits from forks which is the primary workflow for Material open source projects.

@jverkoey
Copy link
Contributor Author

I've filed #12 to explore fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants