Upgrade waves #11
Upgrade waves #11
Conversation
This is 99% original Waves.js code. The only thing added was the initialization on DomLoad in line 31.
js/waves.js
Outdated
| element.addEventListener('touchmove', touchMove, { capture:false, passive: true }); | ||
| element.addEventListener('touchend', hideEffect, { capture:false, passive: true }); | ||
| element.addEventListener('touchcancel', hideEffect, { capture:false, passive: true }); |
There was a problem hiding this comment.
eh I'm not sure about this. Have a look at Dogfalo#4720
There was a problem hiding this comment.
Looks like you're planning on merging passive event receivers already, no? #7
There was a problem hiding this comment.
Isn't this part of waves.js? I guess this is fine because I think the files are completely replaced with the new ones. Correct?
There was a problem hiding this comment.
Isn't this part of waves.js? I guess this is fine because I think the files are completely replaced with the new ones. Correct?
hmm the passive event, no it's not https://github.com/fians/Waves/blob/83fc07e2c0a31a10aa5dc2cf97b965113ddd882c/dist/waves.js#L443-L445
There was a problem hiding this comment.
Ah ok, but I think the 0.8 dev branch is the correct one, the master branch is an old version.
@Waeco please describe from where you got this file / version so we can check this and please split this into two commits. The first one with the new original files and a reference to where it is from and a second commit with your changes.
There was a problem hiding this comment.
@Waeco can you change the commit for the passive listeners according to the proposed solution at MDN?
https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener#Browser_compatibility
There was a problem hiding this comment.
Alternatively we can drop the commit for passive event listeners and do it separately and with a global constant for all parts.
| background: rgba(255,255,255,0.4); | ||
| } | ||
|
|
||
| // Waves Colors |
There was a problem hiding this comment.
add some colors? hmm we might need to add this to the documentation though 😅
|
Thanks for your contribution to materializecss. I've invited you to the materializecss org as member and collaborator. You can view and accept the invitation at https://github.com/materializecss. |
Waves.js library was outdated.
See Dogfalo#5779, Dogfalo#5472 and Dogfalo#3153
This is 99% original Waves.js code. (See: v0.7.6)
Changes:
I am using this in my application for quite some time, seams to work fine.
Moved from Dogfalo#6060