Release 2.0.4 #472
Merged
Release 2.0.4 #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix bug causing menu to toggle
- Fix a bug where multiple clicks on a dropdown trigger would cause the
dropdown to open/close on the 2nd+ clicks
- Behaviour would also occur for the select component which
leverages
the dropdown component
- Special consideration was given to the scenario where a
select
component has a label; where upon clicking the label the
dropdown's _handleClick would be called, but the click
event
would not contain the dropdown-trigger (which is the
select).
Which would previously call both the _handleClick
and
_handleDocumentClick functions causing the same
open/close behaviour
Changed from "var" to "const" in line 157 und 162. Var ist outdated for Javascript const variables.
Update select.html from "var" to "const"
fixes #456 dropdown open/close bug
fix bug causing collapsible to not auto open - Can't exactly explain why it was doing this, but in my development today I noticed that some of my non-accordion collapsibles weren't having their li's with class="active" set on them opening by default. Played around with the code a bit and found that putting these brackets back seemed to resolve it, so here we are
retain dropdown position if the window is resized
fix #467 dropdown + window resize bug
Changed the links to the new domain. Updated dependencies to the newest possible. Removed unused dependencies.
…ependecies Simplifying Dev Process
fix: class="active" non-accordion collapsible not opening by default
…ependecies refactor: remove dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Screenshots (if appropriate) or codepen:
Types of changes
Checklist: