Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate components into folders #614

Open
wants to merge 1 commit into
base: v2-dev
Choose a base branch
from
Open

Seperate components into folders #614

wants to merge 1 commit into from

Conversation

wuda-io
Copy link
Member

@wuda-io wuda-io commented Mar 26, 2025

Proposed changes

Changing the structure, and put components into seperate folder. Later we can also make submodules out of each component. I think this is a cleaner approach and makes life easier.
What do you think?

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@wuda-io wuda-io mentioned this pull request Mar 26, 2025
@joestr
Copy link
Member

joestr commented Apr 4, 2025

I don't see any benefit in separate folders.
What do you exactly mean with submodules? The git ones?
Also I don't really see how that makes the developing easier. Currently every component is in one file.
What would be the benefit if it is in folders?

@joestr
Copy link
Member

joestr commented Apr 4, 2025

I just read the comment in the referenced issue.

If we could make a mono-repo with source +docs I would fullt support this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants