Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add convenience method for obtaining blessed calculation for different functionals #880

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Jan 10, 2024

Summary

  • Convenience function added to MaterialsRester for obtaining blessed calculation entries for different functionals

Todos

  • Add additional function parameters to query structure metadata fields shown here.
  • Add ability to ask for full task document alongside each returned ComputedStructureEntry
  • Add top level convenience function to MPRester

**NOTE: This requires one last deployment of the API service to fix pagination.

@munrojm
Copy link
Member Author

munrojm commented Jan 10, 2024

@shyuep starting this PR now. Need one last deployment this week before you and others can start testing. See TODOs above for my current plan for what to implement.

@shyuep
Copy link
Member

shyuep commented Jan 11, 2024

Thanks

@munrojm
Copy link
Member Author

munrojm commented Jan 29, 2024

Just want to quickly update on this. We have deployed twice in the last couple weeks, but are finding some significant performance problems due to a combination of structural issues with the data in the core DB, and a large volume of API use. This is not allowing nested data in the blessed entries field of the materials endpoint to be queried without timing out. We are still iterating on changes to a number of parts of the stack, including schema and builder changes, offloading queries and data retrieval to S3, and optimizing DB indexing. Will continue to update here in the next week as things progress.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 15.38462% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 67.11%. Comparing base (4d8dba0) to head (de7e2e6).

Files Patch % Lines
mp_api/client/routes/materials/materials.py 15.38% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #880      +/-   ##
==========================================
- Coverage   67.38%   67.11%   -0.27%     
==========================================
  Files          49       49              
  Lines        2520     2533      +13     
==========================================
+ Hits         1698     1700       +2     
- Misses        822      833      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants