-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NEB schemas #1123
Open
esoteric-ephemera
wants to merge
19
commits into
materialsproject:main
Choose a base branch
from
esoteric-ephemera:neb
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add NEB schemas #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1123 +/- ##
==========================================
+ Coverage 90.42% 90.49% +0.07%
==========================================
Files 147 148 +1
Lines 14448 14568 +120
==========================================
+ Hits 13065 13184 +119
- Misses 1383 1384 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
esoteric-ephemera
force-pushed
the
neb
branch
from
November 5, 2024 21:29
461dc08
to
0bbea06
Compare
esoteric-ephemera
force-pushed
the
neb
branch
from
November 21, 2024 01:04
4da5d94
to
3c44175
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for parsing NEB calculations and eventually ApproxNEB calculations. These are still VASP calculations, but have a directory structure which is not parseable by TaskDoc (at least meaningfully). The structure is:
./{INCAR, KPOINTS, POTCAR}
./00/POSCAR
./01/{vasprun.xml, OSZICAR, OUTCAR, CHGCAR, ... }
./02/{vasprun.xml, OSZICAR, OUTCAR, CHGCAR, ... }
...
./0N/POSCAR
Approx / NEB calculations are needed for battery cathode and alloy diffusivity calculations. These schemas will be needed for atomate2 workflows. Once Approx / NEB flows are added to atomate2, we should have full parity with atomate. This will also make it easier to host data from these calculations
Supports parsing NEB calculations (only relaxes images) and NEB + endpoints (three total calculations, two relaxes + one NEB)
Possibly worth adding run / task / calc types? Since this requires a separate doc model, maybe we should avoid this?