breaking: Workflow.from_firework method name capitalization

materialsproject · Apr 9, 2024 · 3076c91 · 3076c91
1 parent f47c01b
commit 3076c91
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/fireworks/core/firework.py b/fireworks/core/firework.py
@@ -1331,10 +1331,10 @@ def from_dict(cls, m_dict: dict[str, Any]) -> Workflow:
                 created_on,
                 updated_on,
             )
-        return Workflow.from_Firework(Firework.from_dict(m_dict))
+        return Workflow.from_firework(Firework.from_dict(m_dict))
 
     @classmethod
-    def from_Firework(cls, fw: Firework, name: str | None = None, metadata=None) -> Workflow:
+    def from_firework(cls, fw: Firework, name: str | None = None, metadata=None) -> Workflow:
         """
         Return Workflow from the given Firework.
 

diff --git a/fireworks/examples/custom_firetasks/hello_world/hello_world_run.py b/fireworks/examples/custom_firetasks/hello_world/hello_world_run.py
@@ -9,7 +9,7 @@
 
     # create the workflow and store it in the database
     my_fw = Firework([HelloTask()])
-    my_wflow = Workflow.from_Firework(my_fw)
+    my_wflow = Workflow.from_firework(my_fw)
     lp.add_wf(my_wflow)
 
     # run the workflow