-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add new MP input sets #3916
base: master
Are you sure you want to change the base?
[WIP] Add new MP input sets #3916
Conversation
LAECHG: True | ||
LASPH: True | ||
LCHARG: True | ||
LELF: False # LELF = True restricts calculation to KPAR = 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it restricts to NPAR = 1 not KPAR = 1. I am not sure where this restriction originates.
There is some logic that expensive-to-compute quantities should be saved by default? (e.g., to my knowledge the only way to recover the KE density from a VASP calculation is to store the ELF)
I see the sense in leaving this as False
but I wonder what should be stored by default? I imagine there is a trade-off with I/O and post-processing time too, especially for simple calculations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The manual says NPAR = 1, but the actual error message I get when I run VASP 6.4.2 (just checked) is: ELF: KPAR>1 not implemented, sorry.
Either way, restricts the parallelization
You can reconstruct the KED from the orbitals in WAVECAR, since those should just be the plane wave coefficients + wave vectors (think we have tools in PMG to parse this but haven't looked thoroughly)
I'm good with LELF = True
for the final static in the MP workflow, since this is usually very cheap (it starts from the WAVECAR of the r2SCAN relaxation)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we hard-code KPAR: 1
for the final static?
Makes sense with the WAVECAR, I am genuinely wondering whether one day we should encourage storage of this by default if storage costs continue to reduce. I am encountering more and more post-processing tools that would really benefit if a large dataset of wave functions were available. I wonder how compressible they are with modern methods too, something I will not have time to investigate unfortunately!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little hesitant to do that, especially if we want to treat larger systems, but it'll require some testing for me to see if KPAR = 1
is a real practical issue
Saving the vaspwave.h5 file might be better in the long run. There's currently an open PR for this, I also need to finish the vaspout.h5 PR
e3fbc67
to
41e6d99
Compare
@esoteric-ephemera is this PR ready for merging? |
@matthewkuner debugging some potential issues with the Ba pseudo (updated to the GW one) - hope to have an update soon |
Copying a suggestion here:
|
This PR adds new MP input sets that resulted from a benchmarking effort over the past year. For the benchmarks, refer to:
Critical updates include:
KSPACING
adjustment by bandgapLREAL = False
LMAXMIX = 6
The updated KSPACING function is slightly different from what was discussed with the MP foundation initially. This is to ensure that calculations with the highest$k$ -point density (KSPACING = 0.22) would not be deprecated by this PR. Previously I recommended that the minimum KSPACING = 0.2, but this is effectively the same as 0.22.
Leaving this up as a WIP pending further community discussion and writing tests