Filtering out already existing tags

[th8m0z]

I've made it possible to filter out already set tags in the book editing view. I did not get the chance to extensively test it, because the current version fails with this error upon adding or editing a book:

SqfliteDatabaseException (DatabaseException(Error Domain=FMDatabase Code=1 "table booksTable has no column named readings" UserInfo={NSLocalizedDescription=table booksTable has no column named readings}) sql 'INSERT INTO booksTable

Can add a separate issue soon.

[mateusz-bak]

Great @th8m0z !

Now readings filed should be added in the database version 7. This should work if you uninstall the app and install clean. But now I'm a bit scared that the updated didn't work.

I did some changes in in #436 , especially here with database change: https://github.com/mateusz-bak/openreads-android/pull/436/files#diff-6d075ff4a7e267a6a1e94238a2c9794cb4f63b4c0e9d8431295d8f80038b13ff

After thisI did #440 that added readings column in the db but I didn't upgrade the db version, so I hope this is caused by this.

[th8m0z]

Yes, reinstalling solved it for me thanks. Will make some more edits to my implementation as right now it's only filtering when tags of the book are already saved, not when the user has just put them in.

[th8m0z]

Hey again, filtering tags even when the book is not saved finally worked, the solution was to just trigger a reload via calling an empty setState after the tag is added.

[mateusz-bak]

Great! Can you fix the merge confilicts?

[th8m0z]

This should work, I think. Tried via the Github editor.

EDIT: GitHub editor doesn't seem to work, I made a mistake during the merge. I'll do this via VSCode.

EDIT 2: Should be fixed now

[th8m0z]

Or is the publication year field no longer relevant?

[mateusz-bak]

Or is the publication year field no longer relevant?

It is, what's the conflict there?

[th8m0z]

With the newest commit, everything should be fine

[mateusz-bak]

I found one issue: When you deselect a tag it is not shown in the propositions.

[th8m0z]

I'll look into it