Adapted to more general truncated power series. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CohenCyril
reviewed
Nov 14, 2019
| @@ -2221,39 +2220,39 @@ Hypothesis gU : g \is a GRing.unit. | |||
|
|
|||
| (** We iterate f := x (g o f) until fixpoint is reached. *) | |||
| (** At each step, the precision is incremented. *) | |||
| Fixpoint lagriter o : {tfps R o} := | |||
| if o is o'.+1 then mulfX ((trXnt o' g) \So (lagriter o')) else 0. | |||
| Fixpoint lagriter O : {tfps R O} := | |||
There was a problem hiding this comment.
It is dangerous to use O as a constant since it is the constructor of the zero nat... we should use a natural number conventional letter such as m, n, p, q, i, j,k or d.
CohenCyril
reviewed
Nov 14, 2019
| @@ -1152,10 +1149,10 @@ Canonical map_tfps_lrmorphism := [lrmorphism of map_tfps]. | |||
|
|
|||
|
|
|||
| (* Tests *) | |||
| Fact test_map_tfps0 : map_tfps 0 = 0. | |||
| Example test_map_tfps0 : map_tfps 0 = 0. | |||
There was a problem hiding this comment.
we might as well remove the tests.
|
Thanks for your contributions, I will merge as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is probably not ready for merge. I anyway posted it to let you know where I'm on that subject.
My main point is to have a common file with https://github.com/hivert/FormalPowerSeries for truncated power series.