Th17 - New Th, Troop, Spell, Hero, & Equipment #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t (so we dont have to mess w/ downloading apk ourself)
doluk
requested changes
Dec 3, 2024
|
Happy to hear thoughts, but does anyone actually look through the json files? Ie. do we need them "beautified"? I did a quick test and just about halved the If people actually look through them I don't hugely mind, but if we have the option it'd be nice to keep this static data small-ish for pypi and releases, and not having enormous git diffs. |
…Introduce new kwargs lookup_cache, update_cache and ignore_cached_errors to handle cache utilization.
…ich should heavily improve readability, reduce errors (because lists get finicky when items aren't there), and in a few cases simplify operations. Additionally changes to accomodate the new hero & to ignore non essential data like temp troops
doluk
requested changes
Dec 24, 2024
Current war index error, cls classes and more cache control
Co-authored-by: Lukas Dobler <[email protected]>
doluk
approved these changes
Jan 1, 2025
doluk
approved these changes
Jan 2, 2025
This was referenced Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated relevant static files & enums