Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce parallel evm via flag #1425

Merged
merged 6 commits into from
Jan 30, 2025
Merged

Enforce parallel evm via flag #1425

merged 6 commits into from
Jan 30, 2025

Conversation

manav2401
Copy link
Contributor

Description

Adds --parallelevm.enforce flag to force bor to only execute blocks in parallel and don't use serial execution at all. This can be used to test the block-stm implementation for every block (as compared to some blocks currently).

Original plan was to maintain this branch separately but maybe it's worth merging this as we can use this internally on devnodes as well instead of keeping this branch up to date.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai/amoy
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@manav2401 manav2401 requested a review from a team January 29, 2025 07:06
docs/cli/server.md Show resolved Hide resolved
core/blockchain.go Show resolved Hide resolved
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 50.34%. Comparing base (6947088) to head (b9ff8c0).
Report is 127 commits behind head on develop.

Files with missing lines Patch % Lines
core/blockchain.go 77.77% 2 Missing ⚠️
eth/backend.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1425      +/-   ##
===========================================
+ Coverage    50.30%   50.34%   +0.03%     
===========================================
  Files          769      771       +2     
  Lines       125643   125779     +136     
===========================================
+ Hits         63209    63322     +113     
- Misses       58398    58408      +10     
- Partials      4036     4049      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manav2401 manav2401 merged commit 8a1e0ec into develop Jan 30, 2025
13 checks passed
@manav2401 manav2401 deleted the enforce-blockstm branch January 30, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants