Fake PR for review #1
Conversation
This reverts commit e58816d.
| use Symfony\Component\HttpFoundation\Session\Flash\FlashBagInterface; | ||
|
|
||
| //todo: demonstrate how include custom js extensions for existing grids maybe?. | ||
| //todo: not a single translation works for this module |
There was a problem hiding this comment.
This is expected, isn't it ? People who wish to translate their modules need to to provide the translations manually or I am wrong ? 🤔
There was a problem hiding this comment.
Well if I want to translate my module now I got this error:
the main reason that for now translations for some reason does not work for the modules using $this->trans('my transaltion', 'Modules.MyModuleName') in module controllers or $this->getTranslator()->trans('my translation', 'Modules.MyModuleName') in main module file.
I know legacy $this->l('my translation') should be working just fine - but I really doubt I should demonstrate legacy transaltions in this module. I see Pablo is working on fixing transaltions.
Maybe these translations will be working soon? If not then maybe I should remove all the transaltions usage and just keep plain strings only? 🤔
There was a problem hiding this comment.
The behavior you explained is a major bug for me. 1.7.6 will not get shipped with this unsolved. So let's put this topic on hold until it's fixed.
|
|
||
|
|
||
| if (isset($exceptionDictionary[$exceptionType])) { | ||
| $flashBag->add('error', $exceptionDictionary[$exceptionType]); |
There was a problem hiding this comment.
its nice but it caused a lot of argues here PrestaShop/PrestaShop#13490. You can check my screenshots there to see why there are many opinions on using this - as I see we not yet decided how to use it 🤔
There was a problem hiding this comment.
Hoho indeed that is a heated debate 😃 🔥
Let's see how it clears out ^^ indeed
| - name: tactician.handler | ||
| command: 'DemoCQRSHooksUsage\Domain\Reviewer\Query\GetReviewerSettingsForForm' | ||
|
|
||
| democqrshooksusage.domain.reviewer.command_handler.update_is_allowed_to_review_handler: |
There was a problem hiding this comment.
We could add in comment a link to the doc that explains how to add commands and handlers
There was a problem hiding this comment.
I don't think we have a dedicated documentation here or do we? 🤔
There was a problem hiding this comment.
|
@tomas862 I created this fake PR in order to put my review comments in an understandable way |
|
Reviewed: still waiting for
|
No description provided.