Document few changes for Matomo 4 #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
approved these changes
Jun 18, 2020
| @@ -107,7 +107,7 @@ _paq.push(['AbTesting::create', { | |||
| } | |||
| return false; | |||
| }, | |||
| matomoTracker: Matomo.getAsyncTracker(piwikUrl, piwikSiteId), | |||
| piwikTracker: Matomo.getAsyncTracker(matomoUrl, matomoSiteId), | |||
There was a problem hiding this comment.
Guess the piwikTracker option hasn't been renamed in the plugin yet?
There was a problem hiding this comment.
exactly, will change the premium feature docs once we renamed things there
Findus23
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs matomo-org/matomo#8415
refs matomo-org/matomo#12420
Updated some docs based on the changelog and also updated some domains, piwik.js and matomo.js mentions etc.