Skip to content

Commit

Permalink
remove old events
Browse files Browse the repository at this point in the history
  • Loading branch information
sgiehl committed Feb 7, 2020
1 parent 808b2ed commit af1f06d
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 20 deletions.
8 changes: 3 additions & 5 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,9 @@ The Product Changelog at **[matomo.org/changelog](https://matomo.org/changelog)*
* The deprecated Platform API class `\Piwik\DeviceDetectorFactory` has been removed. Use `\Piwik\DeviceDetector\DeviceDetectorFactory` instead
* The JavaScript tracker now uses `sendBeacon` by default if supported by the browser. You can disable this by calling the tracker method `disableAlwaysUseSendBeacon`. As a result, callback parameters won't work anymore and a tracking request might not appear in the developer tools.
* The console option `--piwik-domain` has been removed. Use `--matomo-domain` instead
* The core plugin `CustomPiwikJs` was renamed `CustomJsTracker`

### Deprecations
* The event `CustomPiwikJs.piwikJsChanged` has been deprecated. Use `CustomJsTracker.trackerJsChanged` instead
* The event `CustomPiwikJs.shouldAddTrackerFile` has been deprecated. Use `CustomJsTracker.shouldAddTrackerFile` instead
* The core plugin `CustomPiwikJs` was renamed to `CustomJsTracker`
* The event `CustomPiwikJs.piwikJsChanged` has been renamed. Use `CustomJsTracker.trackerJsChanged` instead
* The event `CustomPiwikJs.shouldAddTrackerFile` has been renamed. Use `CustomJsTracker.shouldAddTrackerFile` instead

## Matomo 3.13.1

Expand Down
10 changes: 0 additions & 10 deletions plugins/CustomJsTracker/TrackerUpdater.php
Original file line number Diff line number Diff line change
Expand Up @@ -140,11 +140,6 @@ public function update()
* @param string $absolutePath The path to the new piwik.js file.
*/
Piwik::postEvent('CustomJsTracker.trackerJsChanged', [$savedFile]);

/**
* @todo remove in Matomo 5. For BC only
*/
Piwik::postEvent('CustomPiwikJs.piwikJsChanged', [$savedFile]);
}

}
Expand All @@ -163,11 +158,6 @@ private function updateAlternative($fromFile, $toFile, $newContent)
$savedFiles = $file->save($newContent);
foreach ($savedFiles as $savedFile) {
Piwik::postEvent('CustomJsTracker.trackerJsChanged', [$savedFile]);

/**
* @todo remove in Matomo 5. For BC only
*/
Piwik::postEvent('CustomPiwikJs.piwikJsChanged', [$savedFile]);
}
}
}
Expand Down
5 changes: 0 additions & 5 deletions plugins/CustomJsTracker/TrackingCode/PluginTrackerFiles.php
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,6 @@ protected function shouldIncludeFile($pluginName)
*/
Piwik::postEvent('CustomJsTracker.shouldAddTrackerFile', array(&$shouldAddFile, $pluginName));

/**
* @todo remove in Matomo 5. For BC only
*/
Piwik::postEvent('CustomPiwikJs.shouldAddTrackerFile', array(&$shouldAddFile, $pluginName));

return $shouldAddFile;
}

Expand Down

0 comments on commit af1f06d

Please sign in to comment.