-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename our composer packages #12519
Comments
Hi, I'm willing to use the piwik/piwik package in my project so I'm wondering : if you rename it to matomo/matomo, will I still be able to use piwik/piwik in my composer.json or should I wait until you rename it and use matomo/matomo ? |
@AndoniLarz what exactly are you going to use? It will take a while until we will rename this package, as we will likely do that in Matomo 4. As most of the remaining rename tasks will be done than. See #12420 |
Well I wanted to integrate this package into my Symfony project (using 3.2.13 but soon upgrading to 3.3 or 3.4), and I wanted to know if you were going to rename it promptly so I should wait a bit, or if you were going to let it named piwik for some time. |
Is it possible to create dummy packages? So piwik/piwik requires matomo/matomo? |
I don't think this would make much sense for most of the packages... We are changing the php namespaces for some of the packages, so if we want to provide dummy packages here, we would need to wrap the new namespaces into the old ones to have it still working |
Note that some piwik packages are marked abandoned, but still required by piwik/piwik matomo-org/matomo#12519
Is there something I'm supposed to be doing to fix my existing git installs? Keep getting:
after This doesn't really affect anything, but I've noticed some of my installs have fewer warnings than others. |
you can ignore that messages. We will use the new packages in Matomo 4. |
Thanks. |
Renaming the composer package of device detector can be done somewhen later. I'm planning to to do that with a new major release of Device Detector, but as I didn't have much time to work on that the past months, I will postpone that. But won't hurt in matter of Matomo, as it uses an own namespace, that won't change. Regarding the rename of the piwik/piwik package. Not sure if we should do that with Matomo 4? actually shouldn't hurt to do it and have both package names maybe? |
@sgiehl personally no preference. Can we have easily both names? If that's possible be good. |
Actually like we have it for the components. Even though they are renamed to matomo/* the new releases are still available with the piwik/* name as they use the same repo. For piwik/piwik, we might not even need to mark the package as abandoned if we don't wont to "force" people to switch to the new name |
👍 |
Just release a new major version of device-detector including the rename to |
Our composer packages are still listed under the vendor piwik on packagist. As there is no way to rename them, we need to create new packages and mark the old ones as abandoned
I've already started and will try to rename the other over the next days
piwik/cache
->matomo/cache
(Rename Piwik -> Matomo component-cache#17)-> released as version 2.0.0; usage needs to be implemented in Matomo 4
piwik/decompress
->matomo/decompress
(Rename Piwik -> Matomo component-decompress#12)-> released as version 2.0.0; usage needs to be implemented in Matomo 4
piwik/device-detector
->matomo/device-detector
piwik/ini
->matomo/ini
(Rename Piwik -> Matomo component-ini#8)-> released as version 2.0.0; usage needs to be implemented in Matomo 4
piwik/network
->matomo/network
(Rebrand from Piwik to Matomo component-network#14)piwik/piwik
->matomo/matomo
-> needs to be done in Matomo 4
piwik/piwik-php-tracker
->matomo/matomo-php-tracker
(Rebrand from Piwik to Matomo matomo-php-tracker#51)piwik/referrer-spam-blacklist
->matomo/referrer-spam-blacklist
(Use renamed composer packages #12518)piwik/searchengine-and-social-list
->matomo/searchengine-and-social-list
(Use renamed composer packages #12518)Renaming the php packages does only make sense with Matomo 4, so we can rename all namespaces and classes without the possibility to break any plugins. Imho it doesn't make sense to name the package
matomo/*
but the classes would still need something likeuse Piwik\*
The text was updated successfully, but these errors were encountered: