-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cookie domain config is not applied in ignore cookie preventing opt out to work #15778
Comments
@tsteur Is there any chance this could be triaged to an earlier release? It is an absolutely crippling bug on low-traffic installations because analytics are severely distorted by maintainers' visits. Thank you for your consideration. |
fix #15778 tracker cookie name and path was already set, but not the cookie domain.
@yrammos if you are familiar with applying patches or changes to a file then you could try to apply this and give it a test: https://github.com/matomo-org/matomo/pull/16123/files It might only be merged with Matomo 4.1 though maybe (or earlier). |
@tsteur thank you for responding so briskly. I applied your patch and it appears to be a partial improvement. Before the patch, the ignore cookie was ineffective on all my websites. With the patch, Matomo ignores only visits to websites hosted on Matomo's domain. More specifically:
|
I see... this might actually not going to work then with the tracker proxy... unless you were always using the same domain for all proxies. It may needs a different fix eg in tracker proxy itself or so. |
@tsteur I now noticed that the issue is not limited to the tracker proxy. I can reproduce it exactly as described in my previous post using the JS tracker, as well. Is my case an isolated one? |
This particular issue was actually fixed @yrammos matomo-org/tracker-proxy#58 is still open as you mention it's not fully fixed yet which is because the tracker proxy seems to be needing a fix too to handle this correctly. |
matomo-org/tracker-proxy#58
We need to set similar to the third party cookie https://github.com/matomo-org/matomo/blob/3.13.4/core/Tracker/Request.php#L707-L710 also set the cookie domain here: https://github.com/matomo-org/matomo/blob/3.13.4/core/Tracker/IgnoreCookie.php#L61
The text was updated successfully, but these errors were encountered: