Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set cookie domain if configured on ignore cookie #16123

Closed
wants to merge 1 commit into from
Closed

Set cookie domain if configured on ignore cookie #16123

wants to merge 1 commit into from

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jun 26, 2020

fix #15778

tracker cookie name and path was already set, but not the cookie domain.

@tsteur
Set cookie domain if configured on ignore cookie
b53e10c 
fix #15778 

tracker cookie name and path was already set, but not the cookie domain.
@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jun 26, 2020
@tsteur tsteur added this to the 4.1.0 milestone Jun 26, 2020
@tsteur
Copy link
Member Author

tsteur commented Jun 28, 2020

this is actually done by #13301 so closing it

@tsteur tsteur closed this Jun 28, 2020
@tsteur tsteur deleted the m15778 branch June 28, 2020 22:28
@mattab mattab modified the milestones: 4.1.0, 4.0.0 Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Cookie domain config is not applied in ignore cookie preventing opt out to work
2 participants
@tsteur @mattab