-
Notifications
You must be signed in to change notification settings - Fork 17
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
9fee872
commit 4f6eb49
Showing
1 changed file
with
6 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4f6eb49
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong patch of
matrix->slack
partsimage content
already implemented before I starting contributiontyping notifs
not implemented yet, just work slack->matrix case.:)
4f6eb49
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matrix -> Slack image upload did at one point work, and so did Slack -> Matrix, but Slack API change(s) (ugh!) broke them both. Your contribution fixed Slack -> Matrix, but not Matrix -> Slack (they show up as text attachments with the filename, at least for me)
I marked Matrix-to-Slack typing notifications as supported because a coworker told me it was working (which I didn't understand), but I've just tested with someone else and confirmed that it isn't working, so I'll update the checklist.