Skip to content

Commit

Permalink
Update README.md feature checklist
Browse files Browse the repository at this point in the history
  • Loading branch information
thomas-profitt committed Nov 8, 2018
1 parent 9fee872 commit 4f6eb49
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,18 @@ Restart your HS.
- [ ] Initiating
- Matrix -> Slack
- [x] Text content
- [x] Image content
- [x] Formatted Text content
- [ ] Image content
- [ ] Audio/Video content
- [ ] Typing notifs
- [x] Typing notifs
- [ ] User Profiles
- Slack -> Matrix
- [x] Text content
- [x] Formatted Text content
- [x] Image/Audio/Video content as protected link to slack
- [x] Image/Audio/Video content as upload & embed to matrix
- [ ] Typing notifs
- [x] Image/Audio/Video content message text
- [x] Typing notifs
- [ ] User Profiles
- [ ] Presence
- [x] Third Party Lookup
Expand Down

2 comments on commit 4f6eb49

@d3m3vilurr
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong patch of matrix->slack parts

  • image content already implemented before I starting contribution
  • typing notifs not implemented yet, just work slack->matrix case.

:)

@thomas-profitt
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matrix -> Slack image upload did at one point work, and so did Slack -> Matrix, but Slack API change(s) (ugh!) broke them both. Your contribution fixed Slack -> Matrix, but not Matrix -> Slack (they show up as text attachments with the filename, at least for me)

I marked Matrix-to-Slack typing notifications as supported because a coworker told me it was working (which I didn't understand), but I've just tested with someone else and confirmed that it isn't working, so I'll update the checklist.

Please sign in to comment.