Actually ignore logging disabled modules (#902)

* Actually ignore logging disabled modules * Fix enabled/disabled log config in sample
matrix-org · Sep 15, 2023 · a546c1b · a546c1b
1 parent 92f528e
commit a546c1b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/changelog.d/902.bugfix b/changelog.d/902.bugfix
@@ -0,0 +1 @@
+Let file logs correctly ignore modules matching "logging.files[*].disabled" in the configuration file.
diff --git a/config/config.sample.yaml b/config/config.sample.yaml
@@ -58,13 +58,13 @@ logging:
   lineDateFormat: "MMM-D HH:mm:ss.SSS" # This is in moment.js format
   files:
     - file: "debug.log"
-      disable:
+      disabled:
         - "PresenceHandler" # Will not capture presence logging
     - file: "warn.log" # Will capture warnings
       level: "warn"
     - file: "botlogs.log" # Will capture logs from DiscordBot
       level: "info"
-      enable:
+      enabled:
         - "DiscordBot"
 database:
   # You may either use SQLite or Postgresql for the bridge database, which contains

diff --git a/src/log.ts b/src/log.ts
@@ -78,7 +78,7 @@ export class Log {
     private static setupFileTransport(config: LoggingFile): transports.FileTransportInstance {
         config = Object.assign(new LoggingFile(), config);
         const filterOutMods = format((info, _) => {
-            if (config.disabled.includes(info.module) &&
+            if (config.disabled.includes(info.module) ||
                 config.enabled.length > 0 &&
                 !config.enabled.includes(info.module)
             ) {
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Let file logs correctly ignore modules matching "logging.files[*].disabled" in the configuration file.