Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable reply pings #808

Closed
wants to merge 1 commit into from

Conversation

theCapypara
Copy link

This closes #807 by adding a new option to disable pings.

@Half-Shot Half-Shot requested a review from a team August 9, 2022 10:17
@Half-Shot
Copy link
Contributor

Half-Shot commented Aug 9, 2022

Hi @theCapypara. This looks good, but can you rebase/merge in latest develop so the tests run :). Please also sign off and add a change file as noted in https://github.com/matrix-org/matrix-appservice-bridge/blob/develop/CONTRIBUTING.md.

Copy link

@rollingmoai rollingmoai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #807 (comment):

Discord webhooks have a property called allowed_mentions that allows you to send a message with mentions without pinging people/roles/@everyone (See discord.com/developers/docs/resources/channel#allowed-mentions-object). You can use that to disable pings without removing the mention altogether.

@theCapypara
Copy link
Author

Replaced by #850

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to disable pings for replies (Matrix->Discord)
3 participants