Replace vm2 with quickjs #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
commented
Sep 18, 2023
Also use whether it's set as the indicator of whether transformation functions are allowed, instead of checking the config
- Do it in the constructor instead of in callers - Make hookId mandatory so as to not drop it on some state updates - Conflate a state event's state key with a connection state's name, which was already the case in practice
Better to infer the type instead
|
This should actually be ready now. @Half-Shot give it a look when you can (I can't request a review since this is technically your branch). |
Also refactor similar code
instead of pretending that one was never set
Half-Shot
commented
Sep 25, 2023
There was a problem hiding this comment.
God I wish GitHub let you switch sides in reviews.
I'm minded to say that we want to be extremely careful when changing behaviours here. We're going to be asking people to upgrade ASAP as soon as this is ready, so we don't want to break anything we can avoid. If we can go back to failing on webhook with an error rather than pre-validating, that would be good.
|
✔️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vm2is no longer supported (https://github.com/patriksimek/vm2#%EF%B8%8F-project-discontinued-%EF%B8%8F). In the interests of keeping the experimental transformation function code safe and secure, we've going to try out quickjs within a wasm wrapper to ensure things are still safe to run.This passes our basic sanity tests, but it will likely result in some breakages.