Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Use findPredecessor in RoomNotifs#getUnreadNotificationCount #10067

Merged
merged 2 commits into from
Feb 3, 2023
Merged

Use findPredecessor in RoomNotifs#getUnreadNotificationCount #10067

merged 2 commits into from
Feb 3, 2023

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Feb 3, 2023 •
edited by github-actions bot
Loading

Towards matrix-org/matrix-spec-proposals#3946

closes element-hq/element-web#24326

PSF-1887

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@weeman1337 weeman1337 added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Feb 3, 2023
@weeman1337 weeman1337 requested a review from andybalaam February 3, 2023 10:57
@weeman1337 weeman1337 marked this pull request as ready for review February 3, 2023 10:57
@weeman1337 weeman1337 requested a review from a team as a code owner February 3, 2023 10:57
@weeman1337 weeman1337 requested a review from justjanne February 3, 2023 10:57
germain-gg
germain-gg approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for tightening the tests in that area 🙏

@weeman1337 weeman1337 merged commit 27bd04a into develop Feb 3, 2023
@weeman1337 weeman1337 deleted the weeman1337/room-notifs-predecessor branch February 3, 2023 12:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@germain-gg germain-gg germain-gg approved these changes

@andybalaam andybalaam Awaiting requested review from andybalaam

@justjanne justjanne Awaiting requested review from justjanne justjanne is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gitter sunsetting: Use findPredecessor in RoomNotifs
2 participants
@weeman1337 @germain-gg