Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Migrate SpotlightDialog for dynamic room predecessors #10076

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Feb 3, 2023

Hide rooms that are predecessors according to MSC3946 on the Spotlight dialog.
rec-2023-02-03_14 03 48

Tests only assert that the correct parameter is passed to the mocked MatrixClient.
Other tests should cover that an actual client considers the flag.

Towards matrix-org/matrix-spec-proposals#3946

closes element-hq/element-web#24426

PSF-1895

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@weeman1337 weeman1337 added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Feb 3, 2023
@weeman1337 weeman1337 requested a review from andybalaam February 3, 2023 13:44
@weeman1337 weeman1337 marked this pull request as ready for review February 3, 2023 13:44
@weeman1337 weeman1337 requested a review from a team as a code owner February 3, 2023 13:44
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I added a video proving it works!

@weeman1337 weeman1337 merged commit 97506cb into develop Feb 3, 2023
@weeman1337 weeman1337 deleted the weeman1337/room-predecessors-spotlight branch February 3, 2023 14:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gitter sunsetting: Use findPredecessor in SpotlightDialog
2 participants