This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Playwright: check the welcome page is loaded and works #12660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
requested review from
t3chguy and
MidhunSureshR
and removed request for
a team
richvdh
added
the
T-Task
richvdh
commented
Jun 20, 2024
| page, | ||
| homeserver, | ||
| checkA11y, | ||
| }) => { | ||
| await page.goto("/#/login"); |
There was a problem hiding this comment.
A direct link to /#/login is well-tested by myriad other tests (including the one just below). I don't think we're losing anything by making this test bounce via the welcome page.
t3chguy
approved these changes
Jun 20, 2024
richvdh
force-pushed
the
rav/even_more_integ_tests
branch
from
4f7bd10 to
030ec60
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for an old integration test at https://github.com/element-hq/element-web/blob/v1.11.69/test/app-tests/loading-test.tsx#L191-L216
Based on #12657