fix(sdk-common, wasm): implment JoinHandle correctly #3331
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manmeet Singh <[email protected]>
|
looks like I broke some stuff, my work based on old commit. will fix |
maan2003
force-pushed
the
push-kqoknowkxsno
branch
2 times, most recently
from
e635fec
to
52fc232
Compare
maan2003
commented
Apr 15, 2024
Comment on lines
-62
to
+51
| pub fn abort(&self) { | ||
| self.abort_handle.abort(); | ||
| pub fn abort(&mut self) { |
There was a problem hiding this comment.
note: it requires &mut, but I think it is fine.
maan2003
changed the title
maan2003
force-pushed
the
push-kqoknowkxsno
branch
from
52fc232
to
2a74737
Compare
Signed-off-by: Manmeet Singh <[email protected]>
maan2003
force-pushed
the
push-kqoknowkxsno
branch
from
2a74737
to
928d00b
Compare
|
closing in favor of #3333 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes task getting cancelled on drop of join handle
RemoteHandle already aborts on drop, we don't need abort handle