Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): Add RoomPagination::run_backwards(…, until), take 2 #3491

Merged

Conversation

Hywan
Copy link
Member

@Hywan Hywan commented Jun 3, 2024

#3472 has been reverted in #3477 because the doc' was broken. This PR reverts #3477 and fixes the doc.

@Hywan Hywan requested a review from a team as a code owner June 3, 2024 07:13
@Hywan Hywan requested review from poljar and bnjbvr and removed request for a team and poljar June 3, 2024 07:13
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 83.67%. Comparing base (6012c7d) to head (59924ea).

Files Patch % Lines
crates/matrix-sdk/src/event_cache/pagination.rs 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3491      +/-   ##
==========================================
+ Coverage   83.65%   83.67%   +0.01%     
==========================================
  Files         254      254              
  Lines       25611    25618       +7     
==========================================
+ Hits        21426    21435       +9     
+ Misses       4185     4183       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you <3

@Hywan Hywan merged commit 03b58ea into matrix-org:main Jun 3, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants