chore(ui): Make TimelineInnerMetadata::next_internal_id private
#3526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch updates `TimelineEventHandler` to re-use the public API and avoid using `TimelineInnerMeta::next_internal_id`. The consequence is that `next_internal_id` can now be private instead of public. It's better to have isolated API in this code.
bnjbvr
approved these changes
Jun 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3526 +/- ##
==========================================
- Coverage 83.79% 83.79% -0.01%
==========================================
Files 254 254
Lines 25736 25735 -1
==========================================
- Hits 21565 21564 -1
Misses 4171 4171 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates
TimelineEventHandlerto re-use the public API and avoid usingTimelineInnerMeta::next_internal_id. The consequence is thatnext_internal_idcan now be private instead of public. It's better to have isolated API in this code.RoomEventCache'sVectorDifftoTimeline#3512.EventCachestorage #3280.