fix(sdk): Do not always remove empty chunks from LinkedChunk
#4216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4216 +/- ##
==========================================
+ Coverage 84.86% 84.89% +0.02%
==========================================
Files 272 272
Lines 29167 29171 +4
==========================================
+ Hits 24752 24764 +12
+ Misses 4415 4407 -8 ☔ View full report in Codecov by Sentry. |
poljar
approved these changes
Nov 5, 2024
This patch introduces `EmptyChunk`, a new enum used to represent whether empty chunks must be removed/unlink or kept from the `LinkedChunk`. It is used by `LinkedChunk::remove_item_at`. Why is it important? For example, imagine the following situation: - one inserts a single event in a new chunk (possible if a (sliding) sync is done with `timeline_limit=1`), - one inserts many events at the position of the previous event, with one of the new events being a duplicate of the first event (possible if a (sliding) sync is done with `timeline_limit=10` this time), - prior to this patch, the older event was removed, resulting in an empty chunk, which was removed from the `LinkedChunk`, invalidating the insertion position! So, with this patch: - `RoomEvents::remove_events` does remove empty chunks, but - `RoomEvents::remove_events_and_update_insert_position` does NOT remove empty chunks, they are kept in case the position wants to insert in this same chunk.
Hywan
force-pushed
the
fix-sdk-event-cache-linked-chunk-do-not-delete-empty-chunk
branch
from
6327f98 to
3895f75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces
EmptyChunk, a new enum used to represent whether empty chunks must be removed/unlink or kept from theLinkedChunk. It is used byLinkedChunk::remove_item_at.Why is it important? For example, imagine the following situation:
timeline_limit=1),timeline_limit=10this time),LinkedChunk, invalidating the insertion position!So, with this patch:
RoomEvents::remove_eventsdoes remove empty chunks, butRoomEvents::remove_events_and_update_insert_positiondoes NOT remove empty chunks, they are kept in case the position wants to insert in this same chunk.EventCachestorage #3280