Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): Clarifies what TimelineItemPosition::UpdateDecrypted holds #4330

Merged

Conversation

Hywan
Copy link
Member

@Hywan Hywan commented Nov 26, 2024

(Extracted from #3512)

This patch tries to clear confusion around
TimelineItemPosition::UpdateDecrypted(usize): it does contains a timeline item index. This patch changes to
TimelineItemPosition::UpdateDecrypted { timeline_item_index: usize }


This patch tries to clear confusion around
`TimelineItemPosition::UpdateDecrypted(usize)`: it does contains
a timeline item index. This patch changes to
`TimelineItemPosition::UpdateDecrypted { timeline_item_index: usize }`
@Hywan Hywan marked this pull request as ready for review November 26, 2024 16:27
@Hywan Hywan requested a review from a team as a code owner November 26, 2024 16:27
@Hywan Hywan requested review from andybalaam and removed request for a team November 26, 2024 16:27
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.07%. Comparing base (75d7d07) to head (2d8b6bd).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
crates/matrix-sdk-ui/src/timeline/event_handler.rs 50.00% 4 Missing ⚠️
...tes/matrix-sdk-ui/src/timeline/controller/state.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4330      +/-   ##
==========================================
+ Coverage   85.05%   85.07%   +0.02%     
==========================================
  Files         275      275              
  Lines       30309    30312       +3     
==========================================
+ Hits        25780    25789       +9     
+ Misses       4529     4523       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strong recommend!

@Hywan Hywan merged commit 1c554c4 into matrix-org:main Nov 27, 2024
76 checks passed
@Hywan Hywan mentioned this pull request Nov 28, 2024
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants